Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWIP 2.1.2 tcpip thread stack overflow fix. #10456

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
7 participants
@tymoteuszblochmobica
Copy link
Contributor

commented Apr 23, 2019

Description

Applied missing LWIP patch to PPP/utils.c
"Major Refactoring & extensions" commited on May 23, 201 by hasnainvirk
According to this patch PPP logger module member "ppp_logit" consumes only 256 byte buffer on stack instead of 1024 like original LWIP code from Savanah repo does.

LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@mikaleppanen
@kjbracey-arm
@AriParkkila
@kimlep01

Release Notes

@AriParkkila
Copy link
Contributor

left a comment

It seems that 1600 would be enough e.g. for mbed test -c -m MTB_MTS_DRAGONFLY -n tests-network-interface --app-config=tools/test_configs/CellularInterface.json -vv, but I'm guessing that's still not the worst case..?

@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Im still checking new PPP implementation to verify why more stack is needed. So now 1400 seems ok.

@ciarmcom ciarmcom requested review from AriParkkila, kimlep01, kjbracey-arm, mikaleppanen, SeppoTakalo and ARMmbed/mbed-os-maintainers Apr 25, 2019

@ciarmcom

This comment has been minimized.

@AriParkkila

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@tymoteuszblochmobica I don't think 1400 is enough, could you check my comment above.

@adbridge adbridge added needs: work and removed needs: review labels Apr 25, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@tymoteuszblochmobica I don't think 1400 is enough, could you check my comment above.

@tymoteuszblochmobica Please review

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:multihoming branch from f48b82d to 93cca62 May 7, 2019

LWIP 2.1.2 tcpip thread stack overflow fix.
Applied missing LWIP patch to PPP/utils.c
"Major Refactoring & extensions" commited on May 23, 201 by hasnainvirk
LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:multihoming branch from 93cca62 to 461efaa May 7, 2019

@tymoteuszblochmobica tymoteuszblochmobica changed the title Increase stack size for LWIP 2.1.2 tcpip thread LWIP 2.1.2 tcpip thread stack overflow fix. May 7, 2019

@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Applied missing LWIP patch to PPP/utils.c
"Major Refactoring & extensions" commited on May 23, 201 by hasnainvirk
According to this patch PPP logger module member "ppp_logit" consumes only 256 byte buffer on stack instead of 1024 like original LWIP code from Savanah repo does.

LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes.

@adbridge adbridge added needs: CI and removed needs: work labels May 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 10, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1aa95c0 into ARMmbed:master May 13, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8541 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

This is a 5.13 feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.