Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Add WISE-1570 handling for socket closing URC #10463

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
6 participants
@mirelachirica
Copy link
Contributor

commented Apr 24, 2019

Description

WISE-1570 wasn't handling URC for socket closing at all. Now socket closed flag is set on the arriving of such URC. Also, if the socket was closed but closed flag not yet set at the moment a socket sending/receiving was issued, the socket would get stuck waiting for data. To prevent this, socket event is called also when socket close URC arrives.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mirelachirica mirelachirica force-pushed the mirelachirica:wise_1570_tcp_endpoint_close branch from fd22b7c to af49acb Apr 24, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Apr 25, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-wan Apr 25, 2019

@adbridge adbridge added needs: work and removed needs: review labels Apr 25, 2019

@mirelachirica mirelachirica force-pushed the mirelachirica:wise_1570_tcp_endpoint_close branch from af49acb to 948f8b5 Apr 26, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

@AriParkkila Could you please re-review changes?

@adbridge adbridge added needs: review and removed needs: work labels Apr 26, 2019

@0xc0170 0xc0170 changed the title Cellular: Added WISE-1570 handling for socket closing URC Cellular: Add WISE-1570 handling for socket closing URC May 2, 2019

@0xc0170

0xc0170 approved these changes May 2, 2019

Copy link
Member

left a comment

This is simple change so its fine.

WISE-1570 wasn't handling URC for socket closing at all. Now socket closed flag is set on the arriving of such URC. Also, if the socket was closed but closed flag not yet set at the moment a socket sending/receiving was issued, the socket would get stuck waiting for data. To prevent this, socket event is called also when socket close URC arrives.

This would be nice to have in the commit msg itself.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 2, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 2, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 2, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Client was restart, all OK now

@0xc0170 0xc0170 merged commit 4da21c0 into ARMmbed:master May 3, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8463 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.