Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRAVIS: turn off upload python test code coverage #10524

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
4 participants
@jamesbeyond
Copy link
Contributor

commented May 2, 2019

Description

Turn off upload python test code coverage from TRAVIS.
We are planing to upload C/CPP code coverage to coverall.io later on.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@cmonr

@jamesbeyond jamesbeyond changed the title TRAVIS: trun off upload python test code coverage TRAVIS: turn off upload python test code coverage May 2, 2019

@jamesbeyond jamesbeyond force-pushed the jamesbeyond:travis branch from 88a315f to 2f6078d May 2, 2019

@0xc0170

0xc0170 approved these changes May 2, 2019

@cmonr

cmonr approved these changes May 2, 2019

@0xc0170 0xc0170 added the needs: CI label May 2, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Ci started

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 3, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@jamesbeyond thinking about the release target for this. I am inclined for 5.13.

One question - this python test coverage goes to tools repository (so can be removed here and wont lose this test coverage) ?

@jamesbeyond

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

Hi @0xc0170,
The python code coverage is not for https://github.com/ARMmbed/mbed-os-tools , it is for the tools folder inside mbed-os. the Travis still run the test and generate coverage, but it is just not uploading them, but we are not loosing anything. if there is some mirror repos we can upload to there.

Turn this python code coverage off is for uploading the C/CPP code coverage. which is more useful. I don't think we need to wait for 5.13. because it is not a function change. will not have impact to anyone.
Surely it can be announced in 5.13, let people aware of that.

@adbridge adbridge merged commit 42a9a7a into ARMmbed:master May 7, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8589 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.