Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'LICENSE' file 404 link error in README.md #10525

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
3 participants
@mrcoulter45
Copy link
Contributor

commented May 2, 2019

Description

Fix for the 'LICENSE' file link in the readme that currently 404s.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170 and ARMmbed/mbed-os-maintainers May 2, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@mrcoulter45, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@0xc0170

0xc0170 approved these changes May 2, 2019

Copy link
Member

left a comment

For future reference, removing spaces should be in separate commit

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 2, 2019

@mrcoulter45

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

For future reference, removing spaces should be in separate commit

I can make the spaces another commit if you'd like?

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 3, 2019

It's fine with this doc trivial fix, just for future any other file should have.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Ci started

@0xc0170 0xc0170 merged commit d212638 into ARMmbed:master May 3, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8767 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.