Check in files for the FPGA CI Test Shield #10540

c1728p9 · 2019-05-07T20:42:30Z

Description

Bring all the FPGA CI Test Shield C and C++ driver files into mbed-os as the component FPGA_CI_TEST_SHIELD. When this component is enabled all the files that are needed to communicate with, update firmware on and run testing with the FPGA are built.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mrcoulter45 @maciejbocianski @mprse @fkjagodzinski @0xc0170 @jamesbeyond @donatieng @OPpuolitaival

Release Notes

Added files to control the FPGA CI Test Shield. This allows for enhanced testing.

Bring all the FPGA CI Test Shield C and C++ driver files into mbed-os as the component FPGA_CI_TEST_SHIELD. When this component is enabled all the files that are needed to communicate with, update firmware on and run testing with the FPGA are built.

ciarmcom · 2019-05-07T21:00:36Z

@c1728p9, thank you for your changes.
@mprse @mrcoulter45 @maciejbocianski @donatieng @jamesbeyond @fkjagodzinski @0xc0170 @OPpuolitaival @ARMmbed/mbed-os-maintainers please review.

And fix any build errors this caused.

0xc0170

initial review comments

0xc0170 · 2019-05-08T07:35:37Z

components/testing/COMPONENT_FPGA_CI_TEST_SHIELD/MbedTester.h

+#include "platform/Callback.h"
+#include "drivers/DigitalInOut.h"
+
+class MbedTester {


would it be worth documenting this class (for instance as SPI class has some example and description). Isn't this the most important object for this shield?

I added some documentation and example code.

0xc0170 · 2019-05-08T07:42:18Z

components/testing/COMPONENT_FPGA_CI_TEST_SHIELD/test_utils.h

+    std::list<PortType> matched_ports, not_matched_ports;
+    find_ports<PortType, FormFactorType>(matched_ports, not_matched_ports);
+
+    utest_printf("***Testing one %s pin configuration***\n", PortType::PinMap::name);


why do we use utest_printf and not stdout?

Since this is a test utility shouldn't it use the utest_printf? @maciejbocianski can you comment on this?

Exactly, this utility code is intended to be used in tests only, this is why utest_printf was used

0xc0170 · 2019-05-08T07:45:08Z

components/testing/COMPONENT_FPGA_CI_TEST_SHIELD/test_utils.h

+    }
+};
+
+#if DEVICE_SPI


Can we describe here with a comment what these peripherals utils mean (if I add here, what should I add? ) - small description would help

I added documentation to this.

0xc0170 · 2019-05-08T07:45:52Z

components/testing/COMPONENT_FPGA_CI_TEST_SHIELD/test_utils.h

+    return true;
+}
+
+class DefaultFormFactor {


I've noticed these utils are not much documented in this header file - what this defaultformfactor does ?

I added documentation to this.

Run astyle to correct formatting.

Add documentation to the MbedTester class and the test_utils.h file.

c1728p9 · 2019-05-09T16:31:43Z

Mbed OS CI won't be able to test this until the component FPGA_CI_TEST_SHIELD is added. To get some testing in I created a test branch where this is no longer a component and therefore built as part of CI and manually triggered a CI job on this branch.

0xc0170 · 2019-05-12T19:31:40Z

I've started first test job for this.

0xc0170 · 2019-05-13T14:05:56Z

internal CI fault, restarting IC

mbed-ci · 2019-05-13T17:16:06Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

adbridge · 2019-05-17T09:25:41Z

CI started

mbed-ci · 2019-05-17T13:45:42Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

0xc0170 · 2019-05-21T09:27:58Z

It is almost ready, any more reviews done ?

Mbed OS CI won't be able to test this until the component FPGA_CI_TEST_SHIELD is added. To get some testing in I created a test branch where this is no longer a component and therefore built as part of CI and manually triggered a CI job on this branch.

@OPpuolitaival Can this be added?

bulislaw

Looks good. One thing I'd like to see is docs how to use it. I know that HW is not yet publicly available, but we'll need the docs soon anyway.

mprse

👍

Bring in updates the the FPGA CI Test Shield repo.

c1728p9 · 2019-05-24T01:15:06Z

Added some changes that came in since this PR was created. This should be ready for re-test and merge.

0xc0170 · 2019-05-24T09:22:45Z

Ci restarted

0xc0170 · 2019-05-24T09:24:08Z

@maciejbocianski @c1728p9 Please make sure there is documentation added for this one. This is ready for merging once CI is done

mbed-ci · 2019-05-24T11:53:53Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

ciarmcom requested review from 0xc0170, donatieng, fkjagodzinski, jamesbeyond, maciejbocianski, mprse, mrcoulter45, OPpuolitaival and a team May 7, 2019 21:00

ciarmcom added the needs: review label May 7, 2019

Remove inclusion of mbed.h from FPGA

11bd966

And fix any build errors this caused.

mrcoulter45 approved these changes May 8, 2019

View reviewed changes

maciejbocianski approved these changes May 8, 2019

View reviewed changes

0xc0170 reviewed May 8, 2019

View reviewed changes

Run astyle on all FPGA files

45301ea

Run astyle to correct formatting.

c1728p9 force-pushed the fpga_ci_test_shield branch from 1fd7b1a to 45301ea Compare May 8, 2019 16:01

Add missing documentation

166ff13

Add documentation to the MbedTester class and the test_utils.h file.

0xc0170 added the release-version: 5.13.0-rc1 label May 10, 2019

0xc0170 approved these changes May 10, 2019

View reviewed changes

fkjagodzinski approved these changes May 10, 2019

View reviewed changes

0xc0170 requested a review from bulislaw May 21, 2019 09:27

bulislaw approved these changes May 22, 2019

View reviewed changes

mprse approved these changes May 23, 2019

View reviewed changes

0xc0170 added needs: preceding PR and removed needs: review labels May 23, 2019

Bring in more changes from FPGA repo

e2312c4

Bring in updates the the FPGA CI Test Shield repo.

0xc0170 added needs: CI and removed needs: preceding PR labels May 24, 2019

0xc0170 added ready for merge and removed needs: CI labels May 24, 2019

0xc0170 merged commit a4738fa into ARMmbed:master May 24, 2019

0xc0170 removed the ready for merge label May 24, 2019

martinichka mentioned this pull request Jun 4, 2019

Assertion failed: pcache->block == 0xffffffff #10754

Closed

Check in files for the FPGA CI Test Shield #10540

Check in files for the FPGA CI Test Shield #10540

Uh oh!

Conversation

c1728p9 commented May 7, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented May 7, 2019

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c1728p9 commented May 9, 2019

Uh oh!

0xc0170 commented May 12, 2019

Uh oh!

0xc0170 commented May 13, 2019

Uh oh!

mbed-ci commented May 13, 2019

Uh oh!

adbridge commented May 17, 2019

Uh oh!

mbed-ci commented May 17, 2019

Uh oh!

0xc0170 commented May 21, 2019

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

mprse left a comment

Choose a reason for hiding this comment

Uh oh!

c1728p9 commented May 24, 2019

Uh oh!

0xc0170 commented May 24, 2019

Uh oh!

0xc0170 commented May 24, 2019

Uh oh!

mbed-ci commented May 24, 2019

Uh oh!

Uh oh!