Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: fix Quectel BG96 missing unlock at socket_connect #10579

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
8 participants
@kevinong0108
Copy link
Contributor

commented May 14, 2019

Description

Cellular Quectel BG96 missing call _at.unlock() before return error, it may cause deadlock.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica @jarvte

Release Notes

@ciarmcom ciarmcom requested review from jarvte, mirelachirica and ARMmbed/mbed-os-maintainers May 14, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@jarvte

jarvte approved these changes May 15, 2019

Copy link
Contributor

left a comment

Good catch!

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 6344b9d into ARMmbed:master May 16, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8635 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@kevinong0108 kevinong0108 deleted the kevinong0108:fix_cellular_quectel_bg96 branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.