Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: put the acl buffer size in config #10580

Merged
merged 3 commits into from May 20, 2019

Conversation

Projects
None yet
7 participants
@paul-szczepanek-arm
Copy link
Member

commented May 14, 2019

Description

This is completely non-functional change - this simply puts the acl buffer size in a config file. Comprehensive fix that integrates with the memory pool will be scheduled later.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@paul-szczepanek-arm

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

@cy-kishore please comment if that works for you.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers May 14, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-pan May 14, 2019

@cy-kishore

This comment has been minimized.

Copy link

commented May 15, 2019

This is fine. Please merge this to mainline.

@pan-

pan- approved these changes May 15, 2019

"value": 23
},
"rx-acl-buffer-size": {
"help": "Size of the buffer holding the ACL packet. This will limit the effective ATT_MTU (to its value minus 4 bytes for the header). The size of the buffer must be small enough to be allocated from the existing cordio pool. If this value is increased you may need to adjust the memory pool.",

This comment has been minimized.

Copy link
@pan-

pan- May 15, 2019

Member

It might be worthwhile to explain that it is the size of whole acl packet; not just the buffer used to send fragments.

This comment has been minimized.

Copy link
@paul-szczepanek-arm

paul-szczepanek-arm May 15, 2019

Author Member

Thanks, I have made the wording more explicit.

@cy-kishore

This comment has been minimized.

Copy link

commented May 20, 2019

Hi,
Can you please merge this change and let us know.

regards
Kishore

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 20, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@cy-kishore will try to get this in asap

@mbed-ci

This comment has been minimized.

Copy link

commented May 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 20, 2019

@0xc0170 0xc0170 merged commit 6b7a13f into ARMmbed:master May 20, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8547 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.