-
Notifications
You must be signed in to change notification settings - Fork 3k
Include mbed-greentea==1.7.1 for mbed-os-tools==0.0.8 #10614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include mbed-greentea==1.7.1 for mbed-os-tools==0.0.8 #10614
Conversation
@takuti, thank you for your changes. |
requirements.txt
Outdated
@@ -14,7 +14,7 @@ Jinja2>=2.10.1,<2.11 | |||
intelhex>=1.3,<=2.2.1 | |||
mbed-ls>=1.5.1,<1.8 | |||
mbed-host-tests>=1.4.4,<1.6 | |||
mbed-greentea>=0.2.24,<1.7 | |||
mbed-greentea>=0.2.24,<=1.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you got latest greentea, this fixes the issue. But shouldn't this be <1.8 rather - if we are already going pass 1.7 version
@bridadan Please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ARMmbed/mbed-os-tools mbed-greentea>=0.2.24,<1.8
would be the best here? Locally tested , fixes the error with dependency issue I had today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. Just updated as you suggested. Waiting for review from the other people.
@ARMmbed/mbed-os-tools Please review I am getting now after latest fetch, an error like this:
|
mbed-greentea<1.7 depends on mbed-os-tools<0.0.6, while the other dependent packages require mbed-os-tools=0.0.8. Fixing this inconsistency.
a91c639
to
9bc7e7c
Compare
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
exporters restarted |
mbed-greentea<1.7 depends on mbed-os-tools<0.0.8, while the other
dependent packages require mbed-os-tools=0.0.8. Fixing this
inconsistency.
Description
Current
requirements.txt
doesn't work as:This PR fixes the issue.
Pull request type