Skip to content

Include mbed-greentea==1.7.1 for mbed-os-tools==0.0.8 #10614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019

Conversation

takuti
Copy link
Contributor

@takuti takuti commented May 20, 2019

mbed-greentea<1.7 depends on mbed-os-tools<0.0.8, while the other
dependent packages require mbed-os-tools=0.0.8. Fixing this
inconsistency.

Description

Current requirements.txt doesn't work as:

$ pip install -r requirements.txt
...
$ pip check
mbed-greentea 1.6.5 has requirement mbed-os-tools==0.0.6, but you have mbed-os-tools 0.0.8.

This PR fixes the issue.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@takuti
Copy link
Contributor Author

takuti commented May 20, 2019

Ref ARMmbed/mbed-os-tools#170

@ciarmcom ciarmcom requested a review from a team May 20, 2019 03:00
@ciarmcom
Copy link
Member

@takuti, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

requirements.txt Outdated
@@ -14,7 +14,7 @@ Jinja2>=2.10.1,<2.11
intelhex>=1.3,<=2.2.1
mbed-ls>=1.5.1,<1.8
mbed-host-tests>=1.4.4,<1.6
mbed-greentea>=0.2.24,<1.7
mbed-greentea>=0.2.24,<=1.7.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you got latest greentea, this fixes the issue. But shouldn't this be <1.8 rather - if we are already going pass 1.7 version

@bridadan Please review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ARMmbed/mbed-os-tools mbed-greentea>=0.2.24,<1.8 would be the best here? Locally tested , fixes the error with dependency issue I had today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. Just updated as you suggested. Waiting for review from the other people.

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2019

@ARMmbed/mbed-os-tools Please review

I am getting now after latest fetch, an error like this:

for mbed test command:

Test Case:
    Name: tests-usb_device-serial
    Path: .\TESTS\usb_device\serial
Traceback (most recent call last):
  File "python37-32\lib\site-packages\pkg_resources\__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "python37-32\lib\site-packages\pkg_resources\__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "python37-32\lib\site-packages\pkg_resources\__init__.py", line 791, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (mbed-os-tools 0.0.8 (c:\programs\python37-32\lib\site-packages), Requirement.parse('mbed-os-tools==0.0.6'), {'mbed-greentea'})

mbed-greentea<1.7 depends on mbed-os-tools<0.0.6, while the other
dependent packages require mbed-os-tools=0.0.8. Fixing this
inconsistency.
@takuti takuti force-pushed the fix-dependent-mbed-greentea-version branch from a91c639 to 9bc7e7c Compare May 22, 2019 09:47
@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 22, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2019

exporters restarted

@0xc0170 0xc0170 merged commit 319a82d into ARMmbed:master May 23, 2019
@takuti takuti deleted the fix-dependent-mbed-greentea-version branch May 23, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants