Skip to content

Fastmodel: enable flashIAP and kvstore #10619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2019
Merged

Fastmodel: enable flashIAP and kvstore #10619

merged 5 commits into from
Jul 2, 2019

Conversation

jamesbeyond
Copy link
Contributor

Description

Enable flashIAP and KVStore by setting the base address and size of the flash region

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team May 20, 2019 13:00
@ciarmcom
Copy link
Member

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage please review.

davidsaada
davidsaada approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is Fastmodel the name of the board?

@jamesbeyond
Copy link
Contributor Author

LGTM. Is Fastmodel the name of the board?

FastModel is the name of the simulator, the target names in the mbed-os are:

  • FVP_MPS2_M0
  • FVP_MPS2_M0P
  • FVP_MPS2_M3
  • FVP_MPS2_M4
  • FVP_MPS2_M7

@0xc0170
Copy link
Contributor

0xc0170 commented May 21, 2019

CI started

@jamesbeyond
Copy link
Contributor Author

when testing locally I found a failed test in kvstore:

target platform_name test suite result elapsed_time (sec) copy_method
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-direct_access_devicekey_test TIMEOUT 135.51 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-filesystemstore_tests OK 12.55 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-general_tests_phase_1 OK 16.43 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-general_tests_phase_2 OK 15.64 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-static_tests OK 13.66 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-tdbstore_whitebox OK 12.4 default

It is due to the KVstore use Load$$LR$$LR_IROM1$$Limit as FLASHIAP_APP_ROM_END_ADDR. But on the FVP target the image layout it a bit different, which LR_IROM2 is the APP_ROM_END_ADDR.
I need to make some adjustments to the linker scripts.

@mbed-ci
Copy link

mbed-ci commented May 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented May 21, 2019

@jamesbeyond we will wait for your confirmation, set to "needs: work"

@0xc0170
Copy link
Contributor

0xc0170 commented May 23, 2019

Note, 2 days to get in to 5.13

@0xc0170
Copy link
Contributor

0xc0170 commented May 24, 2019

Please rebase, kvstore configuration changed

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

@jamesbeyond Please rebase, we can start CI asap

@jamesbeyond
Copy link
Contributor Author

kvstore test results:

target platform_name test suite result elapsed_time (sec) copy_method
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-direct_access_devicekey_test OK 10.05 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-filesystemstore_tests OK 10.85 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-general_tests_phase_1 OK 12.43 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-general_tests_phase_2 OK 12.03 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-static_tests OK 11.13 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-kvstore-tdbstore_whitebox OK 9.91 default

flashIAP test results:

target platform_name test suite result elapsed_time (sec) copy_method
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 features-storage-tests-blockdevice-flashsim_block_device OK 10.13 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 tests-mbed_drivers-flashiap OK 10.47 default
FVP_MPS2_M3-ARMC6 FVP_MPS2_M3 tests-mbed_hal-flash OK 10.24 default

@jamesbeyond
Copy link
Contributor Author

The work had finished, this is ready of CI

@jamesbeyond
Copy link
Contributor Author

The work had finished, this is ready of CI
@ARMmbed/mbed-os-maintainers ;-)

@jamesbeyond
Copy link
Contributor Author

Hi @ARMmbed/mbed-os-maintainers, this PR is ready for CI now

@bulislaw
Copy link
Member

bulislaw commented Jul 2, 2019

@ARMmbed/mbed-os-maintainers ping

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2019 •
edited
Loading

😮 this waited a bit for CI, not cool

Started CI

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 149d53c into ARMmbed:master Jul 2, 2019
@jamesbeyond jamesbeyond deleted the fm-iap branch July 2, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@davidsaada davidsaada davidsaada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jamesbeyond @ciarmcom @0xc0170 @mbed-ci @bulislaw @davidsaada