Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesfix usb_device-msd test python dependencies #10621
Conversation
maciejbocianski
force-pushed the
maciejbocianski:usb_msd_deps_fix
branch
from
4a02b65
to
6deb61d
May 21, 2019
ciarmcom
requested review from
c1728p9,
fkjagodzinski and
ARMmbed/mbed-os-maintainers
May 21, 2019
This comment has been minimized.
This comment has been minimized.
|
@maciejbocianski, thank you for your changes. |
ciarmcom
added
the
needs: review
label
May 21, 2019
0xc0170
approved these changes
May 21, 2019
0xc0170
added
needs: CI
and removed
needs: review
labels
May 21, 2019
This comment has been minimized.
This comment has been minimized.
|
CI started |
0xc0170
added
the
release-version: 5.13.0-rc1
label
May 22, 2019
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
May 22, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
ready for merge
and removed
needs: CI
labels
May 22, 2019
0xc0170
merged commit 75100d6
into
ARMmbed:master
May 22, 2019
26 checks passed
continuous-integration/jenkins/pr-head
This commit looks good
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jenkins-ci/build-ARM
Success
Details
jenkins-ci/build-GCC_ARM
Success
Details
jenkins-ci/build-IAR
Success
Details
jenkins-ci/cloud-client-test
Success
Details
jenkins-ci/dynamic-memory-usage
Success
Details
jenkins-ci/exporter
Success
Details
jenkins-ci/greentea-test
Success
Details
jenkins-ci/mbed2-build-ARM
Success
Details
jenkins-ci/mbed2-build-GCC_ARM
Success
Details
jenkins-ci/mbed2-build-IAR
Success
Details
jenkins-ci/unittests
Success
Details
travis-ci/astyle
Success!
Details
travis-ci/docs
Success!
Details
travis-ci/doxy-spellcheck
Success!
Details
travis-ci/events
Success! Runtime is 8789 cycles.
Details
travis-ci/gitattributestest
Success!
Details
travis-ci/include_check
Success!
Details
travis-ci/licence_check
Success!
Details
travis-ci/littlefs
Success! Code size is 8448B.
Details
travis-ci/psa-autogen
Success!
Details
travis-ci/tools-py2.7
Success!
Details
travis-ci/tools-py3.5
Success!
Details
travis-ci/tools-py3.6
Success!
Details
travis-ci/tools-py3.7
Success!
Details
0xc0170
removed
the
ready for merge
label
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
maciejbocianski commentedMay 21, 2019
Description
Add
psutilto requirements.txtIt's required in USB mass storage test
Pull request type
Reviewers
@c1728p9 @fkjagodzinski
Release Notes