Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS: update examples.json to enable testing #10625

Merged
merged 1 commit into from
May 24, 2019

Conversation

jamesbeyond
Copy link
Contributor

@jamesbeyond jamesbeyond commented May 21, 2019

Description

Update examples.json with log compare option to enable example tests.
The built test_spce.json should be upload to S3.

This is targeted at mbed 5.13

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@OPpuolitaival

@ciarmcom ciarmcom requested review from OPpuolitaival and a team May 21, 2019 17:00
@ciarmcom
Copy link
Member

@jamesbeyond, thank you for your changes.
@OPpuolitaival @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0Grit
Copy link

0Grit commented May 21, 2019

Any more insight into how this might be used with custom targets?
Usecases etc.

Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me from a tools PoV.

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2019

Any more insight into how this might be used with custom targets?
Usecases etc.

@jamesbeyond Can you also add description to docs (we have there CI page) - what we are testing in the examples. This should cover how this is used. We have already something when tools were updated to include this (htrun/greentea or similar) ?

@loverdeg-ep What are you after exactly - what we should not miss documenting? This is considered being used in internal CI setup, I would like to understand the use cases you are thinking about.

@40Grit
Copy link

40Grit commented May 22, 2019

@0xc0170

We have our own internal CI/test setup based on gitlab and gitlab runners.

We like to keep tabs on what the team is doing internally so we can come up beside you.

I'm wondering what specifically this enables.

@jamesbeyond
Copy link
Contributor Author

Any more insight into how this might be used with custom targets?
Usecases etc.

This is mean for testing mbed-os-examples, and will be required to use with https://github.com/ARMmbed/mbed-os-example-blinky/tree/master/tests
This is not tie to any type of target

@jamesbeyond
Copy link
Contributor Author

Sure, @0xc0170 I am adding docs to the CI page and adding them together to the CI tasks

@0xc0170
Copy link
Contributor

0xc0170 commented May 23, 2019

Sure, @0xc0170 I am adding docs to the CI page and adding them together to the CI tasks

Please have docs ready this week at least as PR to reference here.

I started CI job

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for documentation reference

@0xc0170
Copy link
Contributor

0xc0170 commented May 23, 2019

Note, 2 days to get in to 5.13

@40Grit
Copy link

40Grit commented May 23, 2019

@0xc0170 Please don't hold this up over documentation.

Creating an issue to capture that this will need documentation is fine with me.

@mbed-ci
Copy link

mbed-ci commented May 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented May 24, 2019

Talking offline to address documentation update

@0xc0170 0xc0170 merged commit 659c099 into ARMmbed:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants