Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cube h7 to 1.4.0 #10631

Merged
merged 2 commits into from May 23, 2019

Conversation

Projects
None yet
5 participants
@VVESTM
Copy link
Contributor

commented May 22, 2019

Description

Update of the cube H7 HAL and LL. This is coming from st.com website : https://www.st.com/en/embedded-software/stm32cubeh7.html
Used version is 1.4.0

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant

@jeromecoutant
Copy link
Contributor

left a comment

Tested OK with ST CI

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Note that this STM32H7 driver version is introducing Dual Core targets, including H747

@facchinm
@MarceloSalazar
@LMESTM

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@VVESTM, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers May 22, 2019

@@ -82,7 +82,7 @@ static const uint16_t USART_PRESCALER_TAB[] =
#endif /*USE_FULL_LL_DRIVER*/

/* Exported types ------------------------------------------------------------*/
#if defined(USE_FULL_LL_DRIVER)
#if 1 //mbed

This comment has been minimized.

Copy link
@0xc0170

0xc0170 May 22, 2019

Member

we dont rather define the macro as 1 instead of rewriting the driver files?

This comment has been minimized.

Copy link
@VVESTM

VVESTM May 23, 2019

Author Contributor

You're right. I have done like this because it was already the case before...
I check how to clean this part.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Let us know once updated, we can start CI.

VVESTM added some commits May 23, 2019

H7 ST CUBE : remove unecessary #if 1 instead of USE_FULL_LL_DRIVER
Keep #define USE_FULL_LL_DRIVER and define this switch in target.json

Signed-off-by: Vincent Veron <vincent.veron@st.com>

@VVESTM VVESTM force-pushed the VVESTM:update_cube_h7 branch from daf1963 to d8e1e43 May 23, 2019

@VVESTM

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

Here is a new version removing the previous #if 1...

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 23, 2019

CI started

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 23, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented May 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 23, 2019

@0xc0170 0xc0170 merged commit 80d7cb2 into ARMmbed:master May 23, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8574 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.