Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of ArrayView with mbed::Span #10659

Merged
merged 2 commits into from Jun 18, 2019

Conversation

@LDong-Arm
Copy link
Contributor

commented May 24, 2019

Description

The public API Span provides the same features as ArrayView (internal to BLE). There's no point to maintain the latter.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan- @paul-szczepanek-arm

@pan-
pan- approved these changes May 24, 2019
Copy link
Member

left a comment

The change looks good. Thanks @LDong-Arm

@ciarmcom ciarmcom requested review from pan-, paul-szczepanek-arm and ARMmbed/mbed-os-maintainers May 24, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 24, 2019

@LDong-Arm LDong-Arm force-pushed the LDong-Arm:replace_ArrayView branch from 39bf7bd to 2baa3c9 May 29, 2019
@LDong-Arm LDong-Arm force-pushed the LDong-Arm:replace_ArrayView branch from 2baa3c9 to 37d13d9 Jun 7, 2019
Copy link
Member

left a comment

Provided that the changes are covered by some tests it LGTM.

@pan-
pan- approved these changes Jun 7, 2019
LDong-Arm added 2 commits May 24, 2019
The platform API mbed::Span provides the same features as ArrayView.
All use of ArrayView within mbed-os have been removed, and
it is not a public API.
@LDong-Arm LDong-Arm force-pushed the LDong-Arm:replace_ArrayView branch from 37d13d9 to 7426a8a Jun 7, 2019
@pan-
pan- approved these changes Jun 7, 2019
@pan-

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

@0xc0170 What's missing for this PR to be tested ?

Copy link
Member

left a comment

tested, merge

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

We will schedule CI once rc3 is out, all needs: CI should get in

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 15, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

Lots of random failures over the weekend. Restarting CI.

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 17, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

CI restarted after smart tester fixes

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 17, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@LDong-Arm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

Looking into the artifacts, there seems to be greentea failures on EV_COG_AD3029LZ and NUCLEO_F429ZI. I'll try to reproduce the issues locally.

@LDong-Arm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

The EV_COG_AD3029LZ failure is an assertion failure and I'll try to reproduce it.

All NUCLEO_F429Z failures have

[HTST][ERR] remote write error: Write response(request_id: ...) timeout!

(I removed the request_id.) @adbridge It looks like an issue with the CI?

@adbridge adbridge added ready for merge and removed needs: CI labels Jun 18, 2019
@adbridge adbridge merged commit 46be526 into ARMmbed:master Jun 18, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-63941 bytes) RAM(-33358 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8634 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@LDong-Arm LDong-Arm deleted the LDong-Arm:replace_ArrayView branch Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.