Skip to content

Add hardcoded Echo server defaults for Greentea socket tests. #10665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2019
Merged

Add hardcoded Echo server defaults for Greentea socket tests. #10665

merged 1 commit into from
Jun 9, 2019

Conversation

tymoteuszblochmobica
Copy link
Contributor

Description

Default setings for Greentea Echo server are now moved to separate header file.
Now socket tests can be built without echo server settings in app JSON configuration file .

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@kjbracey-arm

Release Notes

@ciarmcom ciarmcom requested review from kjbracey, SeppoTakalo and a team May 24, 2019 17:01
@ciarmcom
Copy link
Member

@tymoteuszblochmobica, thank you for your changes.
@SeppoTakalo @kjbracey-arm @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Added hardcoded Echo server defaults for Greentea socket tests. Add hardcoded Echo server defaults for Greentea socket tests. May 27, 2019
0xc0170
0xc0170 requested changes May 27, 2019
View reviewed changes
TESTS/netsocket/test_params.h
@@ -0,0 +1,29 @@
#ifndef MBED_CONF_APP_ECHO_SERVER_ADDR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license header on top of any new file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tymoteuszblochmobica
Copy link
Contributor Author

License header applied

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2019

CI started

@cmonr
Copy link
Contributor

cmonr commented Jun 3, 2019

CI restarted. S3 issues appear addressed.

@mbed-ci
Copy link

mbed-ci commented Jun 4, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

we will restart tests once 5.13rc2 is completed (failures above not related to the changeset)

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2019

Tests will be restarted after rc2 (it did not report back results)

@michalpasztamobica
Copy link
Contributor

michalpasztamobica commented Jun 6, 2019 •
edited
Loading

@0xc0170 , did the release go through? Can we run CI on this? :)

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2019

Ci job restarted

@mbed-ci
Copy link

mbed-ci commented Jun 6, 2019

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2019

I had to abort the job, there were timeouts - other jobs affected, investigating

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 merged commit dd77957 into ARMmbed:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@jussisip jussisip jussisip approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tymoteuszblochmobica @ciarmcom @0xc0170 @cmonr @mbed-ci @michalpasztamobica @SeppoTakalo @VeijoPesonen @jussisip @adbridge