Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: add method to set authentication type to CellularContext #10694

Merged
merged 1 commit into from Jun 21, 2019

Conversation

@jarvte
Copy link
Contributor

commented May 29, 2019

Description

Authentication type must be able to set. It was hard coded to CHAP.
Added unit tests for CellularContext to be able to add test for new function.

Fix for issue: #10551

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

Release Notes

Add new method virtual void set_authentication_type(AuthenticationType type) to CellularContext so application can set the correct authentication type.

@jarvte jarvte force-pushed the jarvte:set_authentication_type branch from 375e3a2 to d61eeb4 May 29, 2019
@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

Force pushed fix for unit test Valgrind run

*
* @param type enum AuthenticationType
*/
virtual void set_authentication_type(AuthenticationType type);

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila May 29, 2019

Contributor

virtual not needed..?

This comment has been minimized.

Copy link
@jarvte

jarvte May 29, 2019

Author Contributor

removed virtual

Authentication type must be able to set. It was hard coded to CHAP.
Added unit tests for CellularContext to be able to add test for new function.
@jarvte jarvte force-pushed the jarvte:set_authentication_type branch from d61eeb4 to 8922eeb May 29, 2019
@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers May 29, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
0xc0170 approved these changes Jun 4, 2019
@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@AnttiKauppila waiting for your review

@adbridge adbridge added needs: CI and removed needs: review labels Jun 18, 2019
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

CI started.

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 19, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

Looks like a license failure in CI, will restart.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels Jun 21, 2019
@adbridge adbridge merged commit 15b5b5d into ARMmbed:master Jun 21, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8642 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.