Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed-crypto: Automatically enable entropy injection #10722

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
7 participants
@Patater
Copy link
Contributor

commented May 31, 2019

Description

Automatically enable entropy injection when the NV Seed feature is
requested on PSA targets. Add a warning note describing the state of the
current implementation of the entropy injection API.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@0xc0170
Copy link
Member

left a comment

Reading about the warning, it might already be there - is there a warning for this "incompatibility" ?

@0xc0170 0xc0170 added the needs: CI label May 31, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

This should fix #10720

@teetak01 Does this fix the issue?

mbed-crypto: Automatically enable entropy injection
Automatically enable entropy injection when the NV Seed feature is
requested on PSA targets. Add a warning note describing the state of the
current implementation of the entropy injection API.

Fixes #10720

@Patater Patater force-pushed the Patater:auto-enable-psa-entropy-injection branch from 5ccf6d1 to 4feb15c May 31, 2019

@Patater

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Reading about the warning, it might already be there - is there a warning for this "incompatibility" ?

There is not a warning, but you'll get a compilation failure if you try to use MBEDTLS_PSA_INJECT_ENTROPY without also opting out of other entropy sources explicitly with MBEDTLS_NO_DEFAULT_ENTROPY_SOURCES.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

@Patater Once "CI started" let us know if any new push. need to abort old CI and restart (I've noticed as browsing issues and found this new reference :) )

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

CI job aborted, started new one

@mbed-ci

This comment has been minimized.

Copy link

commented May 31, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Looks like internal error, latest test runs were OK , restarting CI to confirm

armclang: error: unable to execute command: Terminated

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Ah no, aborted first run, All good, new run in progress 😌

@teetak01
Copy link
Contributor

left a comment

Verified to fix #10720

@mbed-ci

This comment has been minimized.

Copy link

commented May 31, 2019

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Investigating the failures 😕

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

@ARMmbed/mbed-os-test Need your help here to find failures

@mbed-ci

This comment has been minimized.

Copy link

commented May 31, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Exporters restarted

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Restarted again, due to license error

@OPpuolitaival

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

restarted export

@bulislaw
Copy link
Member

left a comment

Approved for RC2. Should it be documented/mentioned in the handbook?

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 4, 2019

@0xc0170 0xc0170 merged commit b050a9d into ARMmbed:master Jun 4, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8702 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.