Cleaned up trace log SPIF Block Device #10756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a conflict - we merged one PR addressing some of the issues here, please rebase and review |
|
I mistakenly branched from an older local master branch indeed. I merged the changes of master and resolved the conflicts. |
added 2 commits
June 4, 2019 16:03
- Test most SPIF log to DEBUG level. - Removed DEBUG/ERROR/INFO tags. - Removed not needed line endings.
martinichka
force-pushed
the
feature-correct-trace-level-storage-spif
branch
from
5f96c75 to
ed36cc4
Compare
|
Now rebased instead |
|
@martinichka, thank you for your changes. |
VeijoPesonen
approved these changes
Jun 5, 2019
0xc0170
approved these changes
Jun 5, 2019
SeppoTakalo
reviewed
Jun 5, 2019
components/storage/blockdevice/COMPONENT_SPIF/SPIFBlockDevice.cpp
Outdated
Show resolved
Hide resolved
|
CI started. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using SPIF Block Device generated a lot of trace log even when trace threshold is set to INFO. Cleaned up trace log SPIF Block Device:
Pull request type
Reviewers
Release Notes