-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doubled ATHandler's BUFF_SIZE #10925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@0xc0170 Please review this change |
jeromecoutant
approved these changes
Jul 1, 2019
@AnttiKauppila, thank you for your changes. |
0xc0170
approved these changes
Jul 1, 2019
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
AnttiKauppila
force-pushed
the
buff_size_fix
branch
from
July 2, 2019 07:18
f8db0db
to
369e2d5
Compare
Will restart tests after watchdog PR completion |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BUFF_SIZE in handle_start method was defined too small for some of our tests. I doubled the value to fix the issue(s).
This fixes Arm internal ref: IOTCELL-2099 issue
Pull request type
Reviewers
Release Notes