Skip form factor pins marked as NC #10984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gpio and gpio_irq FPGA tests run on form factor pins that are marked as NC. This patch changes that behavior so they skip NC pins.
ciarmcom
requested review from
0xc0170,
fkjagodzinski,
maciejbocianski,
mprse and
a team
|
@c1728p9, thank you for your changes. |
cmonr
approved these changes
Jul 6, 2019
0xc0170
approved these changes
Jul 8, 2019
|
CI started |
maciejbocianski
approved these changes
Jul 8, 2019
fkjagodzinski
approved these changes
Jul 8, 2019
artokin
added
needs: CI
release-version: 5.14.0-rc1
release-version: 5.13.1
and removed
needs: review
release-version: 5.14.0-rc1
labels
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gpio and gpio_irq FPGA tests run on form factor pins that are marked as NC. This patch changes that behavior so they skip NC pins.
Pull request type
Reviewers
@maciejbocianski @mprse @fkjagodzinski @0xc0170