Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Enlarge LPTICKER_DELAY_TICKS for safe #11021

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@ccli8
Copy link
Contributor

commented Jul 11, 2019

Description

On Nuvoton targets, lp_ticker_set_interrupt(...) needs around 3 lp-ticker ticks to take effect. It may miss when current tick and match tick are very close (see hal/LowPowerTickerWrapper.cpp). This PR enlarges LPTICKER_DELAY_TICKS to 4 from 3 to address this boundary case.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
[Nuvoton] Enlarge LPTICKER_DELAY_TICKS for safe
On Nuvoton targets, lp_ticker_set_interrupt(...) needs around 3 lp-ticker
ticks to take effect. It may miss when current tick and match tick are very
close (see hal/LowPowerTickerWrapper.cpp). Enlarge LPTICKER_DELAY_TICKS to
4 from 3 to address this boundary case.
@0xc0170
Copy link
Member

left a comment

On Nuvoton targets, lp_ticker_set_interrupt(...) needs around 3 lp-ticker ticks to take effect. It may miss when current tick and match tick are very close (see hal/LowPowerTickerWrapper.cpp). Enlarge LPTICKER_DELAY_TICKS to 4 from 3 to address this boundary case.

👍 what I asked in your earlier PR for deepsleep , this one to be there as well

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

Any update?

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@0xc0170 0xc0170 added the needs: CI label Aug 9, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 9, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Tracking issue for exporters failure: #11209

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 14, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels Aug 15, 2019

@adbridge adbridge merged commit 08ecbfc into ARMmbed:master Aug 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge Manually fixed status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8586 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.