Skip to content

Fix watchdog tests failing with OOM #11022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2019
Merged

Fix watchdog tests failing with OOM #11022

merged 2 commits into from
Jul 15, 2019

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jul 11, 2019

Description

This PR is to fix watchdog tests failing with OOM on targets with just 16KiB RAM.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

ccli8 added 2 commits July 10, 2019 14:31
@ccli8
Fix mbed_drivers-watchdog failing with OOM
debc38f 
This is to fix OOM error on targets with just 16KiB RAM.
@ccli8
Fix mbed_hal-watchdog failing with OOM
81dd2aa 
This is to fix OOM error on targets with just 16KiB RAM.
0xc0170
0xc0170 reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding, the default one would be 4k - too much for the test?

Otherwise, LGTM

@ccli8
Copy link
Contributor Author

ccli8 commented Jul 11, 2019

To my understanding, the default one would be 4k - too much for the test?

Yes. Thread stack size defaults to 4k. This test doesn't need so much.

@ciarmcom ciarmcom requested review from a team July 11, 2019 09:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-core @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 removed the request for review from a team July 11, 2019 09:02
@evedon
Copy link
Contributor

evedon commented Jul 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@artokin artokin merged commit aca726d into ARMmbed:master Jul 15, 2019
@ccli8 ccli8 deleted the nuvoton_wdt-test-oom branch July 16, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.13.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ccli8 @ciarmcom @evedon @mbed-ci @0xc0170 @fkjagodzinski @artokin