Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: allow overriding event signal #11058

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@paul-szczepanek-arm
Copy link
Member

commented Jul 16, 2019

Description

Function that signals events from controller can not be overridden by porter. This changes makes it weak making it possible to decouple host from controller.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

This makes no change to existing code and users. Only affects future porters.

@pan-
pan- approved these changes Jul 16, 2019
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jul 16, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Lgtm. @ARMmbed/mbed-os-maintainers Stareted CI since @paul-szczepanek-arm PM'd me, and I think y'all were already out. 😅

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 16, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

CI restarted.

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 17, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@evedon

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Aborted previous CI job and restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@evedon

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

travis-ci/events restarted

@SeppoTakalo SeppoTakalo merged commit 2f136b9 into ARMmbed:master Jul 17, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8649 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@evedon evedon removed the ready for merge label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.