Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gpio-irq pinmap #11074

Merged
merged 5 commits into from Jul 29, 2019

Conversation

@fkjagodzinski
Copy link
Member

commented Jul 19, 2019

Description

This patch adds a gpio_irq_pinmap() function that is used for GPIO IRQ testing with the FPGA shield. This is a follow-up to #10644; the default implementation returns a PinMap that is exactly the same as GPIO PinMap. Every target has to override this weak implementation to provide a correct list of pins to test.

I also updated the tests-mbed_hal_fpga_ci_test_shield-gpio_irq test to make use of gpio_irq_pinmap().

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mmahadevan108 @c1728p9 @maclobdell @maciejbocianski

Release Notes

Add a weak gpio_irq_pinmap(), that every target has to override, to provide a set of pins for GPIO IRQ testing.

@ciarmcom ciarmcom requested review from c1728p9, maciejbocianski, maclobdell and ARMmbed/mbed-os-maintainers Jul 19, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Copy link
Member

left a comment

LGTM

@SeppoTakalo SeppoTakalo added needs: CI and removed needs: review labels Jul 22, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Jul 22, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

@fkjagodzinski Please fix the build failures

[2019-07-22T13:58:20.820Z] [2019-07-22T13:58:20.820Z] [Error] objects.h@40,5: unknown type name 'gpio_irq_event'

[2019-07-22T13:58:20.820Z] [2019-07-22T13:58:20.820Z] [Error] objects.h@41,5: unknown type name 'gpio_irq_handler'

[2019-07-22T13:58:20.820Z] [2019-07-22T13:58:20.820Z] Failed to build library

Failed builds (at least):

  • FUTURE_SEQUANA ARM
  • FUTURE_SEQUANA_M0 ARM
  • GR_LYCHEE ARM
  • UBLOX_EVK_ODIN_W2 ARM
@SeppoTakalo SeppoTakalo added needs: work and removed needs: CI labels Jul 23, 2019
@fkjagodzinski fkjagodzinski force-pushed the fkjagodzinski:pinmap-gpio_irq branch from 6f3a779 to b92c653 Jul 23, 2019
@fkjagodzinski

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Build failures should be fixed now.

@lrusinowicz Could you review the patch I made for PSOC6_FUTURE (8448640)?

@fkjagodzinski

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

travis-ci/events job failed with fragmenting_barrage_test: failed at line 92. I don't think this patch could interfere with events tests. I'm unable to reproduce this failure locally with make -C events/equeue/ test.

@SeppoTakalo could you restart that Travis job please?

Use the gpio_irq_pinmap() for GPIO-IRQ testing.
Include the gpio_irq_api header to fix build failures.
The use of `gpio_irq_event` & `gpio_irq_handler` in `gpio_irq_s` creates
a circular dependency.

hal/gpio_irq_api.h needs
targets/TARGET_Cypress/TARGET_PSOC6_FUTURE/TARGET_CY8C63XX/device.h, that needs
targets/TARGET_Cypress/TARGET_PSOC6_FUTURE/objects.h, that again needs
hal/gpio_irq_api.h, before the types are defined.

Remove `#include "gpio_irq_api.h"` directive from objects.h and change
the types of `gpio_irq_s` members.
@fkjagodzinski fkjagodzinski force-pushed the fkjagodzinski:pinmap-gpio_irq branch from b92c653 to 8448640 Jul 25, 2019
@fkjagodzinski

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Rebased to current master (c5c7458) and resolved conflicts.

@SeppoTakalo SeppoTakalo added needs: CI and removed needs: work labels Jul 26, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Jul 26, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@mprse
mprse approved these changes Jul 29, 2019
@SeppoTakalo SeppoTakalo merged commit 417a9fe into ARMmbed:master Jul 29, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8569 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@fkjagodzinski fkjagodzinski deleted the fkjagodzinski:pinmap-gpio_irq branch Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.