Skip to content

ARMC5 <array> extensions #11076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2019
Merged

ARMC5 <array> extensions #11076

merged 4 commits into from
Jul 23, 2019

Conversation

kjbracey
Copy link
Contributor

Description

Extensions for ARMC5 <array>:

  • Comparison operators
  • Tuple interface
  • Permit zero size
  • Remove constexpr from methods - ARMC5 refuses to accept with complex types

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan-

@kjbracey kjbracey changed the title Mstd ARMC5 <array> extensions Jul 19, 2019
@kjbracey
Copy link
Contributor Author

kjbracey commented Jul 19, 2019 •
edited
Loading

Re the tuple interface - I do have a hopefully-fully-functional ARMC5 C++11 <tuple> that I'll look at pulling in when I return.

@ciarmcom ciarmcom requested review from pan- and a team July 19, 2019 15:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mbed-ci
Copy link

mbed-ci commented Jul 22, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 7dacafa into ARMmbed:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

+1 more reviewer

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.14.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjbracey @ciarmcom @mbed-ci @pan- @SeppoTakalo