Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMC5 <array> extensions #11076

Merged
merged 4 commits into from Jul 23, 2019

Conversation

@kjbracey-arm
Copy link
Contributor

commented Jul 19, 2019

Description

Extensions for ARMC5 <array>:

  • Comparison operators
  • Tuple interface
  • Permit zero size
  • Remove constexpr from methods - ARMC5 refuses to accept with complex types

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan-

@kjbracey-arm kjbracey-arm changed the title Mstd ARMC5 <array> extensions Jul 19, 2019
@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Re the tuple interface - I do have a hopefully-fully-functional ARMC5 C++11 <tuple> that I'll look at pulling in when I return.

@ciarmcom ciarmcom requested review from pan- and ARMmbed/mbed-os-maintainers Jul 19, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

@kjbracey-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@pan-
pan- approved these changes Jul 19, 2019
@SeppoTakalo SeppoTakalo added needs: CI and removed needs: review labels Jul 22, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Jul 22, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 7dacafa into ARMmbed:master Jul 23, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8616 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.