Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EP_AGORA target pinout #11099

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@trowbridgec
Copy link
Contributor

commented Jul 23, 2019

Description

Updates the PinNames.h file for the EP_AGORA target. The pinout changed in a significant way between HW rev 1.0 and 1.1. By default, we now assume HW rev 1.1, but you can force HW rev 1.0 by defining a macro named EP_AGORA_HW_REV_1_0 (most easily from the mbed_app.json file).

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@maclobdell
@ARMmbed/team-embeddedplanet

@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Jul 23, 2019
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@trowbridgec Please clean up your Git history. It contains merge commit and therefore looks like it contains more changes than your commits.

Remove the merge commit, rebase your changes on top of master, and force-push the branch again.
Thanks.

@trowbridgec trowbridgec force-pushed the trowbridgec:update-ep-agora-pinout branch from 289d55a to 35932a3 Jul 26, 2019
@trowbridgec trowbridgec force-pushed the trowbridgec:update-ep-agora-pinout branch from 35932a3 to 04ca01d Jul 26, 2019
@trowbridgec

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

@SeppoTakalo Sorry about that...should be good to go now.

@SeppoTakalo SeppoTakalo removed request for ARMmbed/mbed-os-core Jul 29, 2019
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo requested a review from ARMmbed/team-embeddedplanet Jul 29, 2019
@SeppoTakalo SeppoTakalo removed the needs: CI label Jul 29, 2019
@loverdeg-ep

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

@maclobdell, @deepikabhavnani, @ygoyal18 , @x85446, @jjohnson-arm , @WendyHead

Please note that if compiling an application for the Agora's you have; after this PR you will need to specify via app_config.json that you have a 1.0 board revision.

Feel free to exchange your 1.0 for a 1.1 via request for RMA to my email or info@embeddedplanet.com

@loverdeg-ep

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@SeppoTakalo SeppoTakalo merged commit e69a7c9 into ARMmbed:master Aug 5, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8556 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.