Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freescale: fix i2c_byte_read function #11141

Merged

Conversation

@maciejbocianski
Copy link
Member

commented Aug 1, 2019

Description

Fix i2c_byte_read implementation for Freescale Xpresso targets
single byte read test gets stuck in i2c_byte_read while reading first byte

before:
| target       | platform_name | test suite                             | result  | elapsed_time (sec) | copy_method |
|--------------|---------------|----------------------------------------|---------|--------------------|-------------|
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | TIMEOUT | 33.65              | default     |
mbedgt: test suite results: 1 TIMEOUT
mbedgt: test case report:
| target       | platform_name | test suite                             | test case                            | passed | failed | result | elapsed_time (sec) |
|--------------|---------------|----------------------------------------|--------------------------------------|--------|--------|--------|--------------------|
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - init/free test all pins        | 1      | 0      | OK     | 0.75               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test read i2c API              | 1      | 0      | OK     | 0.45               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte read i2c API  | 0      | 0      | ERROR  | 0.0                |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte write i2c API | 1      | 0      | OK     | 0.47               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test write i2c API             | 1      | 0      | OK     | 0.47               |

after:
| target       | platform_name | test suite                             | test case                            | passed | failed | result | elapsed_time (sec) |
|--------------|---------------|----------------------------------------|--------------------------------------|--------|--------|--------|--------------------|
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - init/free test all pins        | 1      | 0      | OK     | 0.75               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test read i2c API              | 1      | 0      | OK     | 0.45               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte read i2c API  | 1      | 0      | OK     | 0.47               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte write i2c API | 1      | 0      | OK     | 0.47               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test write i2c API             | 1      | 0      | OK     | 0.47

obraz

Pull request type

[X] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-hal

Release Notes

@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Aug 1, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@maciejbocianski, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@maclobdell

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@ARMmbed/team-nxp - please review

@SeppoTakalo SeppoTakalo requested a review from ARMmbed/team-nxp Aug 5, 2019

@jamesbeyond
Copy link
Contributor

left a comment

Looks good

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@mmahadevan108
Copy link
Contributor

left a comment

Thank you.

@SeppoTakalo SeppoTakalo merged commit 1e4a837 into ARMmbed:master Aug 6, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8762 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.