Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate USB target specific code to root `targets` directory #11142

Merged
merged 6 commits into from Aug 20, 2019

Conversation

@hugueskamba
Copy link
Contributor

commented Aug 1, 2019

Description

All target specific source and header files should be in the targets
directory located at the root of the Mbed OS repository.

@bulislaw, please add the relevant partners as reviewers. Thank you

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@evedon @bulislaw

@ciarmcom ciarmcom requested review from bulislaw, evedon, maclobdell, toyowata and ARMmbed/mbed-os-maintainers Aug 1, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@hugueskamba, thank you for your changes.
@toyowata @maclobdell @bulislaw @evedon @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

left a comment

@maclobdell @ARMmbed/team-cypress please review the relocation of USB files for Cypress targets
@hugueskamba the Freescale and NXP files are definitely moved to a wrong place as there's no other files in this directory. @maclobdell @ARMmbed/team-nxp please advice what's the best home for these files
@linlingao can you have a look at the implementation for Nordic please
@toyowata @ARMmbed/team-renesas could you please review the Renesas files
@MarceloSalazar @ARMmbed/team-st-mcd please review the STM files

@hugueskamba the TARGET_Template is a template or example of how to implement the USB support, can we move it to mbed-os/hal/usb/

@linlingao

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

For Nordic, I would move the files to targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840

@loverdeg-ep

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@AGlass0fMilk looks like you need to review.

@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

For Nordic, I would move the files to targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840
@linlingao
b250717

@0xc0170 0xc0170 added needs: work and removed needs: review labels Aug 8, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@maclobdell @ARMmbed/team-cypress please review the relocation of USB files for Cypress targets
@hugueskamba the Freescale and NXP files are definitely moved to a wrong place as there's no other files in this directory. @maclobdell @ARMmbed/team-nxp please advice what's the best home for these files
@linlingao can you have a look at the implementation for Nordic please
@toyowata @ARMmbed/team-renesas could you please review the Renesas files
@MarceloSalazar @ARMmbed/team-st-mcd please review the STM files

Please review to help us progress with this targets USB files.

@linlingao

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Nordic files are now moved to the more logical place. Thanks for the change.

@loverdeg-ep

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@AGlass0fMilk Last chance to review.

@AGlass0fMilk

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

If the build still works then it’s fine w/ me. Looks to be more logical (rather than having a usb folder sticking out)

@hugueskamba hugueskamba force-pushed the hugueskamba:hk-usb-targets-relocation branch from b250717 to ccb4d64 Aug 9, 2019
@hugueskamba

This comment has been minimized.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Aug 9, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@hugueskamba the TARGET_Template is a template or example of how to implement the USB support, can we move it to mbed-os/hal/usb/

This was not yet done as I can see in the files

@0xc0170
0xc0170 approved these changes Aug 9, 2019
Copy link
Member

left a comment

Besides the template, the rest looks fine to me

@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Besides the template, the rest looks fine to me

Moving USB template files to mbed-os/hal/usb
bab4edb

@jamesbeyond

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Hi @fkjagodzinski, you might want to be aware of this change as well. The test files been moved already.

@svozcy

This comment has been minimized.

Copy link

commented Aug 13, 2019

The Cypress Targets has a consistent names for the driver files implementation, for instance cy_gpio_api.c. The proposal is to rename usb files as follow: cy_usb_phy_hw.h and cy_usb_phy.cpp.

@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

The Cypress Targets has a consistent names for the driver files implementation, for instance cy_gpio_api.c. The proposal is to rename usb files as follow: cy_usb_phy_hw.h and cy_usb_phy.cpp.

9dc1d24

@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Cannot reproduce travis-ci/events failure with cd mbed-os/events/source && make test.
All test pass:

hugkam01 at e121095-lin in ~/projects/mbed-os-projects/mbed-os/events/source on hk-usb-targets-relocation [$]
$ make test
gcc -c -MMD -O2 -I. -I.. -I../.. -std=c99 -Wall -D_XOPEN_SOURCE=600 tests/tests.c -o tests/tests.o
gcc -c -MMD -O2 -I. -I.. -I../.. -std=c99 -Wall -D_XOPEN_SOURCE=600 equeue_posix.c -o equeue_posix.o
gcc -c -MMD -O2 -I. -I.. -I../.. -std=c99 -Wall -D_XOPEN_SOURCE=600 equeue.c -o equeue.o
gcc -O2 -I. -I.. -I../.. -std=c99 -Wall -D_XOPEN_SOURCE=600 tests/tests.o equeue_posix.o equeue.o -pthread -o tests/tests
tests/tests
beginning tests...
simple_call_test: passed
simple_call_in_test: passed
simple_call_every_test: passed
simple_post_test: passed
destructor_test: passed
allocation_failure_test: passed
cancel_test: passed
cancel_inflight_test: passed
cancel_unnecessarily_test: passed
loop_protect_test: passed
break_test: passed
break_no_windup_test: passed
period_test: passed
nested_test: passed
sloth_test: passed
background_test: passed
chain_test: passed
unchain_test: passed
multithread_test: passed
simple_barrage_test: passed
fragmenting_barrage_test: passed
multithreaded_barrage_test: passed
break_request_cleared_on_timeout: passed
sibling_test: passed
done!

@0xc0170 Do you have any suggestion?

@hugueskamba hugueskamba force-pushed the hugueskamba:hk-usb-targets-relocation branch from 9dc1d24 to 3d6fb15 Aug 16, 2019
@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

The force-push rebased from master to restart the CI as the cause of the failure is unknown.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Ci started

@0xc0170 0xc0170 requested a review from bulislaw Aug 19, 2019
@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 19, 2019
@bulislaw

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

What about the mbed-os/usb directory? Is it still needed?

@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

What about the mbed-os/usb directory? Is it still needed?

@bulislaw It will be empty and git only considers files not folders so it is automatically gone.
Thank you
fdc4702

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 19, 2019

Test run: FAILED

Summary: 5 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

I'll restart Ci once approved after the latest change

@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 20, 2019
@0xc0170 0xc0170 merged commit e3bfcbc into ARMmbed:master Aug 20, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8651 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@hugueskamba hugueskamba deleted the hugueskamba:hk-usb-targets-relocation branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.