Relocate USB target specific code to root `targets` directory #11142

hugueskamba · 2019-08-01T07:36:44Z

Description

All target specific source and header files should be in the targets
directory located at the root of the Mbed OS repository.

@bulislaw, please add the relevant partners as reviewers. Thank you

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@evedon @bulislaw

ciarmcom · 2019-08-01T09:00:28Z

@hugueskamba, thank you for your changes.
@toyowata @maclobdell @bulislaw @evedon @ARMmbed/mbed-os-maintainers please review.

bulislaw

@maclobdell @ARMmbed/team-cypress please review the relocation of USB files for Cypress targets
@hugueskamba the Freescale and NXP files are definitely moved to a wrong place as there's no other files in this directory. @maclobdell @ARMmbed/team-nxp please advice what's the best home for these files
@linlingao can you have a look at the implementation for Nordic please
@toyowata @ARMmbed/team-renesas could you please review the Renesas files
@MarceloSalazar @ARMmbed/team-st-mcd please review the STM files

@hugueskamba the TARGET_Template is a template or example of how to implement the USB support, can we move it to mbed-os/hal/usb/

linlingao · 2019-08-02T15:43:07Z

For Nordic, I would move the files to targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840

0Grit · 2019-08-02T16:53:06Z

@AGlass0fMilk looks like you need to review.

hugueskamba · 2019-08-05T06:24:56Z

For Nordic, I would move the files to targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840
@linlingao
b250717

0xc0170 · 2019-08-08T12:17:01Z

@maclobdell @ARMmbed/team-cypress please review the relocation of USB files for Cypress targets
@hugueskamba the Freescale and NXP files are definitely moved to a wrong place as there's no other files in this directory. @maclobdell @ARMmbed/team-nxp please advice what's the best home for these files
@linlingao can you have a look at the implementation for Nordic please
@toyowata @ARMmbed/team-renesas could you please review the Renesas files
@MarceloSalazar @ARMmbed/team-st-mcd please review the STM files

Please review to help us progress with this targets USB files.

linlingao · 2019-08-08T15:00:07Z

Nordic files are now moved to the more logical place. Thanks for the change.

0Grit · 2019-08-08T16:14:35Z

@AGlass0fMilk Last chance to review.

AGlass0fMilk · 2019-08-08T17:26:31Z

If the build still works then it’s fine w/ me. Looks to be more logical (rather than having a usb folder sticking out)

hugueskamba · 2019-08-09T08:58:07Z

Force pushed (https://github.com/ARMmbed/mbed-os/compare/b250717ea2ad0942cd043d2c84a45ea8544ff6ce..ccb4d64d3783c7c646309096fe49f6e6a17e2a5e) to fix merge conflicts.

0xc0170 · 2019-08-09T11:59:52Z

@hugueskamba the TARGET_Template is a template or example of how to implement the USB support, can we move it to mbed-os/hal/usb/

This was not yet done as I can see in the files

0xc0170

Besides the template, the rest looks fine to me

hugueskamba · 2019-08-12T07:11:41Z

Besides the template, the rest looks fine to me

Moving USB template files to mbed-os/hal/usb
bab4edb

jamesbeyond · 2019-08-12T14:47:00Z

Hi @fkjagodzinski, you might want to be aware of this change as well. The test files been moved already.

svozcy · 2019-08-13T06:11:24Z

The Cypress Targets has a consistent names for the driver files implementation, for instance cy_gpio_api.c. The proposal is to rename usb files as follow: cy_usb_phy_hw.h and cy_usb_phy.cpp.

hugueskamba · 2019-08-13T07:27:39Z

The Cypress Targets has a consistent names for the driver files implementation, for instance cy_gpio_api.c. The proposal is to rename usb files as follow: cy_usb_phy_hw.h and cy_usb_phy.cpp.

9dc1d24

hugueskamba · 2019-08-14T13:01:54Z

Cannot reproduce travis-ci/events failure with cd mbed-os/events/source && make test.
All test pass:

hugkam01 at e121095-lin in ~/projects/mbed-os-projects/mbed-os/events/source on hk-usb-targets-relocation [$]
$ make test
gcc -c -MMD -O2 -I. -I.. -I../.. -std=c99 -Wall -D_XOPEN_SOURCE=600 tests/tests.c -o tests/tests.o
gcc -c -MMD -O2 -I. -I.. -I../.. -std=c99 -Wall -D_XOPEN_SOURCE=600 equeue_posix.c -o equeue_posix.o
gcc -c -MMD -O2 -I. -I.. -I../.. -std=c99 -Wall -D_XOPEN_SOURCE=600 equeue.c -o equeue.o
gcc -O2 -I. -I.. -I../.. -std=c99 -Wall -D_XOPEN_SOURCE=600 tests/tests.o equeue_posix.o equeue.o -pthread -o tests/tests
tests/tests
beginning tests...
simple_call_test: passed
simple_call_in_test: passed
simple_call_every_test: passed
simple_post_test: passed
destructor_test: passed
allocation_failure_test: passed
cancel_test: passed
cancel_inflight_test: passed
cancel_unnecessarily_test: passed
loop_protect_test: passed
break_test: passed
break_no_windup_test: passed
period_test: passed
nested_test: passed
sloth_test: passed
background_test: passed
chain_test: passed
unchain_test: passed
multithread_test: passed
simple_barrage_test: passed
fragmenting_barrage_test: passed
multithreaded_barrage_test: passed
break_request_cleared_on_timeout: passed
sibling_test: passed
done!

@0xc0170 Do you have any suggestion?

All target specific source and header files should be in the `targets` directory located at the root of the Mbed OS repository.

hugueskamba · 2019-08-16T14:44:16Z

The force-push rebased from master to restart the CI as the cause of the failure is unknown.

0xc0170 · 2019-08-19T07:49:14Z

Ci started

bulislaw · 2019-08-19T09:30:22Z

What about the mbed-os/usb directory? Is it still needed?

hugueskamba · 2019-08-19T09:43:19Z

What about the mbed-os/usb directory? Is it still needed?

@bulislaw It will be empty and git only considers files not folders so it is automatically gone.
Thank you
fdc4702

mbed-ci · 2019-08-19T09:47:27Z

Test run: FAILED

Summary: 5 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_cloud-client-test
jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR
jenkins-ci/mbed-os-ci_dynamic-memory-usage

0xc0170 · 2019-08-19T09:47:34Z

I'll restart Ci once approved after the latest change

hugueskamba · 2019-08-19T11:10:43Z

CI started

mbed-ci · 2019-08-19T23:23:47Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

ciarmcom requested review from bulislaw, evedon, maclobdell, toyowata and a team August 1, 2019 09:00

ciarmcom added the needs: review label Aug 1, 2019

bulislaw suggested changes Aug 2, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Aug 8, 2019

hugueskamba force-pushed the hk-usb-targets-relocation branch from b250717 to ccb4d64 Compare August 9, 2019 08:57

0xc0170 added needs: review and removed needs: work labels Aug 9, 2019

0xc0170 approved these changes Aug 9, 2019

View reviewed changes

0xc0170 approved these changes Aug 12, 2019

View reviewed changes

mmahadevan108 approved these changes Aug 15, 2019

View reviewed changes

hugueskamba added 5 commits August 16, 2019 15:42

Relocate USB target specific code to root targets directory

5cbc3e0

All target specific source and header files should be in the `targets` directory located at the root of the Mbed OS repository.

Rename template dir so future templates can be added to the same dir.

41346ba

Relocate TARGET_MCU_NRF52840 to TARGET_NRF5x/TARGET_NRF52

f3df1c1

Move USB Templates to mbed-os/hal/usb

de231b8

Use consistant naming for Cypress USB target files.

3d6fb15

hugueskamba force-pushed the hk-usb-targets-relocation branch from 9dc1d24 to 3d6fb15 Compare August 16, 2019 14:43

toyowata approved these changes Aug 19, 2019

View reviewed changes

0xc0170 requested a review from bulislaw August 19, 2019 07:49

0xc0170 added needs: CI and removed needs: review labels Aug 19, 2019

0xc0170 added the release-version: 5.14.0-rc1 label Aug 19, 2019

Remove USB mbed_lib.json to remove mbed-os/usb as it is now empty.

fdc4702

bulislaw approved these changes Aug 19, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Aug 20, 2019

0xc0170 merged commit e3bfcbc into ARMmbed:master Aug 20, 2019

0xc0170 removed the ready for merge label Aug 20, 2019

hugueskamba deleted the hk-usb-targets-relocation branch September 10, 2019 07:55

Relocate USB target specific code to root targets directory #11142

Relocate USB target specific code to root targets directory #11142

Uh oh!

Conversation

hugueskamba commented Aug 1, 2019

Description

Pull request type

Reviewers

Uh oh!

ciarmcom commented Aug 1, 2019

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

linlingao commented Aug 2, 2019

Uh oh!

0Grit commented Aug 2, 2019

Uh oh!

hugueskamba commented Aug 5, 2019

Uh oh!

0xc0170 commented Aug 8, 2019

Uh oh!

linlingao commented Aug 8, 2019

Uh oh!

0Grit commented Aug 8, 2019

Uh oh!

AGlass0fMilk commented Aug 8, 2019

Uh oh!

hugueskamba commented Aug 9, 2019

Uh oh!

0xc0170 commented Aug 9, 2019

Uh oh!

0xc0170 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hugueskamba commented Aug 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamesbeyond commented Aug 12, 2019

Uh oh!

svozcy commented Aug 13, 2019

Uh oh!

hugueskamba commented Aug 13, 2019

Uh oh!

hugueskamba commented Aug 14, 2019

Uh oh!

hugueskamba commented Aug 16, 2019

Uh oh!

0xc0170 commented Aug 19, 2019

Uh oh!

bulislaw commented Aug 19, 2019

Uh oh!

hugueskamba commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Aug 19, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Aug 19, 2019

Uh oh!

hugueskamba commented Aug 19, 2019

Uh oh!

mbed-ci commented Aug 19, 2019

Test run: SUCCESS

Uh oh!

Uh oh!

Relocate USB target specific code to root `targets` directory #11142

Relocate USB target specific code to root `targets` directory #11142

0xc0170 left a comment •

edited

Loading

hugueskamba commented Aug 12, 2019 •

edited

Loading

hugueskamba commented Aug 19, 2019 •

edited

Loading