Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__cplusplus guard fixed pwmout_device.h for STM32F4 #11150

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@byq77
Copy link
Contributor

commented Aug 1, 2019

Description

This bug prevented using this header in cpp code directly.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
__cplusplus guard fixed
This error prevented using this header in cpp code directly.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Aug 1, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@byq77, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
0xc0170 approved these changes Aug 8, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit d27867e into ARMmbed:master Aug 9, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8549 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 9, 2019

@LMESTM

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

LGTM - but loks like it needs to be fixed on other STM32 families as well
I will send a PR to complete this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.