Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular API shutdown to stop state machine #11154

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@AriParkkila
Copy link
Contributor

commented Aug 2, 2019

Description

Fixed CellularDevice::shutdown() to stop cellular state machine and DISCONNECTED event handling in AT_CellularContext.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

Release Notes

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-shutdown-stm branch from ced591f to ed3562e Aug 2, 2019
@ciarmcom ciarmcom requested review from mirelachirica and ARMmbed/mbed-os-maintainers Aug 2, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

@jarvte
jarvte approved these changes Aug 5, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 46a56fb into ARMmbed:master Aug 6, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8794 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Moving to 5.14. There are conflicts with 5.13 (few lines around this changeset were changed and I am not confident applying this patch there).
If needed, please create PR to 5.13 branch that we could cherry pick for the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.