Nuvoton: Remove dead code nu_delay_cycle_x4 #11160
Merged
+0
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, nu_delay_cycle_x4(...) is borrowed from mbed test code for delay cycle. Currently, it is not used on Nuvoton targets. If delay cycle is needed, use wait_ns(...) instead which has strict implementation and has passed tests.
|
@ccli8, thank you for your changes. |
Ronny-Liu
approved these changes
Aug 5, 2019
SeppoTakalo
approved these changes
Aug 5, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally,
nu_delay_cycle_x4(...)is borrowed from mbed test code for delay cycle. Currently, it is not used on Nuvoton targets. If delay cycle is needed, usewait_ns(...)instead which has strict implementation and has passed tests.Pull request type