Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upNuvoton: Remove dead code nu_delay_cycle_x4 #11160
Conversation
ciarmcom
requested review from
Ronny-Liu and
ARMmbed/mbed-os-maintainers
Aug 5, 2019
This comment has been minimized.
This comment has been minimized.
|
@ccli8, thank you for your changes. |
ciarmcom
added
the
needs: review
label
Aug 5, 2019
SeppoTakalo
approved these changes
Aug 5, 2019
SeppoTakalo
added
needs: CI
and removed
needs: review
labels
Aug 5, 2019
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Aug 5, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
SeppoTakalo
added
ready for merge
release-version: 5.13.3
and removed
needs: CI
labels
Aug 6, 2019
SeppoTakalo
merged commit fae1504
into
ARMmbed:master
Aug 6, 2019
26 checks passed
SeppoTakalo
removed
the
ready for merge
label
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ccli8 commentedAug 5, 2019
Description
Originally,
nu_delay_cycle_x4(...)is borrowed from mbed test code for delay cycle. Currently, it is not used on Nuvoton targets. If delay cycle is needed, usewait_ns(...)instead which has strict implementation and has passed tests.Pull request type