Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: moved string_to_pdp_type from AT_CellularContext to Cellula… #11200

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@jarvte
Copy link
Contributor

commented Aug 12, 2019

Description

string_to_pdp_type is a common method for AT and other layers. Without moving there will be duplicate methods.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kivaisan

Release Notes

Moved string_to_pdp_type from AT_CellularContext to CellularUtil. string_to_pdp_type is a common method for AT and other layers. Without moving there will be duplicate methods.

…rUtil

string_to_pdp_type is a common method for AT and other layers.
Without moving there will be duplicate methods.
@ciarmcom ciarmcom requested review from kivaisan and ARMmbed/mbed-os-maintainers Aug 12, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@jarvte, thank you for your changes.
@kivaisan @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-wan Aug 12, 2019
@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 12, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Tracking issue for exporters failure: #11209

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 14, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_pdmc-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

jenkins-ci/mbed-os-ci_pdmc-test

Should be gone from config , can be ignored here, not valid.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 14, 2019
@0xc0170 0xc0170 merged commit 0a73eda into ARMmbed:master Aug 14, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge Manually fixed status
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8762 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@jarvte jarvte deleted the jarvte:move_string_to_pdp_type branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.