Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomics: GCC fix for M23 (again) #11208

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@kjbracey-arm
Copy link
Contributor

commented Aug 13, 2019

Description

Add another missing unified syntax directive. Was previously fixed in 03f1ac3, but the same problem was not addressed in the pending PR that added the NEWVAL_2OP assembler.

Fixes #11102.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Targets 5.14, as fixing PR #10274.

Reviewers

@ccli8

Add another missing unified syntax directive. Was previously fixed in
03f1ac3, but the same problem was not addressed in the pending PR that
added the `NEWVAL_2OP` assembler.
@ccli8
ccli8 approved these changes Aug 14, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

CI started

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 14, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 14, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels Aug 15, 2019
@adbridge adbridge merged commit 033fffe into ARMmbed:master Aug 15, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8595 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.