Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review follow-up mstd fixes #11211

Merged
merged 3 commits into from Aug 20, 2019

Conversation

@kjbracey-arm
Copy link
Contributor

commented Aug 13, 2019

Description

Minor fixes to #11039 - following up review comments from there.

  • Fix README.md typo
  • Drop dead ARMC5 std::reference_wrapper code
  • Fix mstd::not_fn

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Targeting 5.14.0, as fixing new feature.

Reviewers

@pan-

@ciarmcom ciarmcom requested review from pan- and ARMmbed/mbed-os-maintainers Aug 13, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@kjbracey-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@kjbracey-arm kjbracey-arm changed the title Mstd Review follow-up mstd fixes Aug 13, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

CI started while finalizing reviews

Copy link
Contributor

left a comment

LGTM

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 19, 2019
@pan-
pan- approved these changes Aug 19, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 20, 2019
@0xc0170 0xc0170 merged commit 73d6aa5 into ARMmbed:master Aug 20, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8759 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.