Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in USBSerial.h function prevents compilation #11260

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@rvasquez6089
Copy link

commented Aug 19, 2019

Description

In one of attach function calls in the USBSerial class, the object pointer is flipped with the location of the static location of the function. This prevents code from compiling when using the the attach function properly. Just a small typo that needed fixing.

rx = mbed::Callback<void()>(mptr, tptr); <--- Incorrect

rx = mbed::Callback<void()>(tptr, mptr); <----Correct
to match this function prototype ---> Callback(U *obj, R(T::*method)())

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 19, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

@rvasquez6089, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

CI restarted

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

cc @mbed-os-test - also this one - client test failing

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

cc @mbed-os-test - also this one - client test failing

Known issue, will be restarted once fixed

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 28daa3f into ARMmbed:master Aug 22, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8707 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@bulislaw

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

How is that tested that we didn't catch this issue? @jamesbeyond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.