Enable building feature storage with a bare metal profile #11275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2019 10:32
To compile Mbed Bootloader with bare metal profile certain defines are not added anymore automatically. Because of this checks for those defines needed to be introduced.
Built testsTest results |
ciarmcom
requested review from
JanneKiiskila,
michalpasztamobica,
SeppoTakalo,
teetak01 and
a team
|
@VeijoPesonen, thank you for your changes. |
SeppoTakalo
approved these changes
Aug 21, 2019
|
IMHO, if you are breaking existing software by changing the default, it would be nice to add documentation to commit message how to keep existing software (such as MCC) building and running. |
|
Yep, migration guides needed. |
Besides commit msg as mentioned above, also why are we doing this? Provide a reason so users who come back with "why did you do this?" find the answer in the release notes and in the commit as well.
+1 |
|
@teetak01, @JanneKiiskila, @0xc0170 PR's description updated. Please check if the updated version is sufficient. |
teetak01
approved these changes
Aug 22, 2019
|
Hipsut are not the right ones there, they should be, i.e. You will get plus points by supplying the piece of text one needs to copy paste to |
|
@JanneKiiskila description updated. |
|
No nyt on timanttia!-) |
JanneKiiskila
approved these changes
Aug 22, 2019
0xc0170
approved these changes
Aug 22, 2019
|
@bulislaw Please review I'll start CI meanwhile |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
|
That's a breaking change that should go to major release. That being said I would like us to deprecated nvstore in 5.15 and possibly remove it in 6. |
@VeijoPesonen What can we do here to get this in to the next minor ? |
|
Well, at least some of the test case failures seem to be unrelated to these changes. Need to admit that I haven't gone through all of those. @0xc0170 You wouldn't happen to know if this error is a symptom about some wider issue? |
NUCLEO_F429ZI issuesThe issues seem to be possibly related to RAAS usage or may be to a certain mbedgt version. Tests will pass if run on a local machine. Switching to another RAAS instance didn't seem to have any effect. Fails in RAASPasses locallymbedgt version |
|
There was an error also in CI, let me restart tests, however as noted above, this is not for 5.14 is it? 5.14 jobs are prioritized. |
This reverts commit bda7678.
|
@0xc0170 Problem solved - I reverted the part where NVStore is set as disabled. Rest should go in. I'll update the description of this PR. |
|
@0xc0170 PR's description updated. Now it should be ready for 5.14. @bulislaw , @JanneKiiskila Fine by you? |
VeijoPesonen
changed the title
|
Btw, this is not a breaking change anymore. |
|
@0xc0170 - this is definitely for 5.14, please tag it matchingly. |
0xc0170
added
release-version: 5.14.0-rc1
needs: CI
and removed
BREAKING-CHANGE
needs: review
labels
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables building storage with bare metal profile.
To compile Mbed Bootloader with bare metal profile certain defines are
not added anymore automatically. Because of this checks for those
defines needed to be introduced.
Pull request type
Reviewers
@SeppoTakalo
@teetak01
@michalpasztamobica
@JanneKiiskila
Release Notes