Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSSI getter fixed for ESP8266 #11304

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@AnttiKauppila
Copy link
Contributor

commented Aug 23, 2019

Description

ESP8266 RSSI getter issue fixed: #11252
Issue was caused because for scan() a callback was added for results and rssi() adopted same mechanism but code was not updated to reflect changes.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@star297
@ARMmbed/mbed-os-wan

Release Notes

@AnttiKauppila AnttiKauppila force-pushed the AnttiKauppila:esp8266_fix branch from 4c91dd1 to a074721 Aug 23, 2019
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 23, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

@AnttiKauppila, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 27, 2019

Test run: FAILED

Summary: 3 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@0xc0170 0xc0170 added the rollup PR label Aug 28, 2019
@0xc0170 0xc0170 referenced this pull request Aug 28, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

This is now part of roll up PR: #11358

Please do not change this PR, or if you do, let us know asap

@0xc0170 0xc0170 removed the rollup PR label Aug 28, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

I suspect this has a failure with client test, restarting rollup and will report back

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Client passed in the rollup without this PR, I'll start CI here to get results here as well

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 28, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Internal error, code -11, restarting the build

cc @ARMmbed/mbed-os-test

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Restarted CI

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

One example got breaking change, its fixed now but need to abort + restart current job here

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 28, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 29, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Looks like all good !

@0xc0170 0xc0170 merged commit 56a8227 into ARMmbed:master Aug 29, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8490 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@star297

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

I still get RSSI result as 0

Using this example:
https://os.mbed.com/teams/mbed-os-examples/code/mbed-os-example-wifi/

Terminal output:

WiFi example
Mbed OS version 5.13.1

Scan:
Network: Molino Metz secured: None BSSID: 2C:5D:93:2:c4:b8 RSSI: -40 Ch: 3
Network: Molino secured: None BSSID: 2C:5D:93:9:86:8 RSSI: -85 Ch: 4
2 networks available.

Connecting to Molino Metz...
Success

MAC: 18:fe:34:a0:80:f7
IP: 192.168.1.42
Netmask: 255.255.255.0
Gateway: 192.168.1.1
RSSI: 0

Done

Not sure why the Mbed-os version is showing 5.13.1 my Revision History indicates 5.14.0-1

@AnttiKauppila

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

@star297 Example was not updated for 5.14. Should work now

@star297

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Thank's, just found that out, does work on Revision 6689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.