Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266: Support power pin in custom wiring #11343

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@ccli8
Copy link
Contributor

commented Aug 27, 2019

Description

This PR tries to support power pin in custom wiring for the ESP8266 module. It allows for the following configurations:

  • Power pin name
  • Power pin polarity
  • Power on/off time

Related PR

Replacement for #11299 and #11331

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@michalpasztamobica @kjbracey-arm

Release Notes

@ciarmcom ciarmcom requested review from kjbracey-arm, michalpasztamobica and ARMmbed/mbed-os-maintainers Aug 27, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Copy link
Contributor

left a comment

This looks much more like it. I'd just clarify the help text a bit.

@@ -78,7 +78,7 @@ class ESP8266Interface : public NetworkStack, public WiFiInterface {
* @param rx RX pin
* @param debug Enable debugging
*/
ESP8266Interface(PinName tx, PinName rx, bool debug = false, PinName rts = NC, PinName cts = NC, PinName rst = NC);
ESP8266Interface(PinName tx, PinName rx, bool debug = false, PinName rts = NC, PinName cts = NC, PinName rst = NC, PinName pwr = NC);

This comment has been minimized.

Copy link
@kjbracey-arm

kjbracey-arm Aug 27, 2019

Contributor

This is a binary compatibility break, but I guess this isn't a core enough component for that to be an issue.

"value": 0
},
"power-on-time-ms": {
"help": "Power-on time in ms for the modem",

This comment has been minimized.

Copy link
@kjbracey-arm

kjbracey-arm Aug 27, 2019

Contributor

Clarify this to delay after powering on modem.

This comment has been minimized.

Copy link
@ccli8

ccli8 Aug 27, 2019

Author Contributor

Modified

In custom wiring, there can be a power pin to power on/off the modem. This
commit supports it and allows for the following configurations:

- power pin name
- power pin polarity
- power on/off delay time
@ccli8 ccli8 force-pushed the OpenNuvoton:nuvoton_esp8266_power_pin branch from c3bec41 to 650e2e5 Aug 27, 2019
@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 27, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 28, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

CI restarted (internal timeout fault)

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 98c0fd0 into ARMmbed:master Aug 29, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8573 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.