-
Notifications
You must be signed in to change notification settings - Fork 3k
Enable tickless mode in MAX32630FTHR #11463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gpsimenos, thank you for your changes. |
"PORTIN", | ||
"PORTINOUT", | ||
"PORTOUT", | ||
"PWMOUT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit this separately please - removing dead space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @0xc0170 did you want the removal of dead space in a separate PR or just a separate commit in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separate commit would work but as there are multiple commits, separate PR is easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please edit the first commit message to clearly list the targets for which tickless has been enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changing release to 5.15 as this is a target change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for the code change to enable tickless.
One comment left by Martin for the dead spaces.
Ci started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
Last force push removes failing target. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Hi there, Made a clean build and the problem described in #12493 is solved. If i undo the change in targets.json and clean build the code then the issue is back again. It seems this merge has not been tested properly, please either undo this merge or solve the bug it introduces in crucial functions like wait(), wait_ms(), ThisThread::sleep_for(), etc. |
Description
This PR is part of IOTCLOUDPR-3223. The requirement is to enable tickless mode in targets that CI can run tests on. In this first PR, tickless mode is enabled in MAX32630FTHR, which successfully passed all greentea tests with tickless mode.
An additional PR may follow with more targets that currently show minor greentea regressions, after it is confirmed tickless mode is not the cause.
Pull request type
Reviewers
@evedon @hugueskamba