Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTEST: add atecc608a example to compilation test #11475
Conversation
"mbed": [], | ||
"test-repo-source": "github", | ||
"features" : [], | ||
"targets" : ["K64F"], |
This comment has been minimized.
This comment has been minimized.
Patater
Sep 12, 2019
Contributor
Any target with I2C should work, although maybe this list is how you keep integration testing from growing too big.
This comment has been minimized.
This comment has been minimized.
jamesbeyond
Sep 16, 2019
Author
Contributor
That is might depends on which target in the RaaS got the atecc608a
shield. Also it is true we don't want to compile the exampled for too many target, it will not slow down the testing process
"test" : false, | ||
"baud_rate": 9600, | ||
"compare_log": ["mbed-os-example-atecc608a/tests/atecc608a.log"], | ||
"auto-update" : true |
This comment has been minimized.
This comment has been minimized.
Patater
Sep 12, 2019
Contributor
Is examples.json the place to specify which RaaS tag
is required to run the example (in this case, it'd be HAS_CRYPTOKIT
)
This comment has been minimized.
This comment has been minimized.
jamesbeyond
Sep 16, 2019
Author
Contributor
This file has no control of which tatget in RaaS to use at moment. but no harm to put the info here, we'll need to sort that out in the test part
LGTM other than Jaeden's comments |
This comment has been minimized.
This comment has been minimized.
CI started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Sep 13, 2019
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
This comment has been minimized.
This comment has been minimized.
We may also need to restrict which compilers this example runs with, as Microchip's cryptoauthlib (which we depend on) doesn't build with ARMC or IAR. |
This comment has been minimized.
This comment has been minimized.
CI restarted, internal fault |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Sep 16, 2019
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
This comment has been minimized.
This comment has been minimized.
@jamesbeyond Please review. The latest build failures are for all toolchains. There is a code 1 returned from the script and failing for this addition. |
@@ -469,9 +469,9 @@ | |||
"github": "https://github.com/ARMmbed/mbed-os-example-atecc608a", | |||
"mbed": [], | |||
"test-repo-source": "github", | |||
"features" : [], | |||
"features" : ["HAS_CRYPTOKIT"], |
This comment has been minimized.
This comment has been minimized.
Patater
Sep 16, 2019
Contributor
Does this "features" setting correlate at all with the RaaS tag? There is no HAS_CRYPTOKIT Mbed OS feature.
This comment has been minimized.
This comment has been minimized.
HI @0xc0170 @Patater ,
I think this is because the example in the folder of Any explaination why the example have a extra |
This comment has been minimized.
This comment has been minimized.
The Mbed TLS example testing CI needs each example to be in its own folder so we can test it. For Mbed OS CI, I think some |
This comment has been minimized.
This comment has been minimized.
CI restarted |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Sep 16, 2019
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
This comment has been minimized.
This comment has been minimized.
CI restarted |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Sep 16, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This comment has been minimized.
This comment has been minimized.
The last question for this one to land, @jamesbeyond Please review . otherwise looks good to me |
This comment has been minimized.
This comment has been minimized.
@0xc0170, I believe I do need to revisit this PR, and changed the |
This comment has been minimized.
This comment has been minimized.
I reverted the feature tag of |
This comment has been minimized.
This comment has been minimized.
CI restarted |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Sep 17, 2019
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This failure is different from previous one, the reason for this is because our build testing configured to build from the root of the example folder, where the actual example is build from a sub folder inside root example folder. the solutions would be. for temperate fixing: Long term fixing: |
This comment has been minimized.
This comment has been minimized.
@jamesbeyond what is the state of this ? |
This comment has been minimized.
This comment has been minimized.
as far as I can see, this won't make to 5.14.1, because the example changes is on going. this will to wait for another PR, which is not created yet. So let's postpone it to 5.14.2 @adbridge |
This comment has been minimized.
This comment has been minimized.
This PR will need to wait #11710 to be merged first |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Nov 1, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This comment has been minimized.
This comment has been minimized.
The update of scripts is done. and In this PR the new example been added, also the temporarily turned off sub examples are turned back on for complication tests. Seems the CI passed as expected, I think this PR is good to go @ARMmbed/mbed-os-maintainers |
jamesbeyond commentedSep 12, 2019
Description
add atecc608a example to compilation test
Pull request type
Reviewers
@adbridge
Release Notes