-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iar export: fix invalid optmization flag - remove from misc #11498
Conversation
The exported project uses project file to set optimization, we can provide this via misc options. It was recently changed to Ol and this was not handled in our scripts.
I was able to reproduce the failure. And test this fix, all working with it. |
cc @OPpuolitaival - this should fix nightly failures for iar export. |
Can someone please check that this now works as expected with the IAR tools? Apparently the check would normally only be done on a nightly run (see https://jira.arm.com/browse/MBEDOSTEST-757 comment) |
I manually tested, but one more test would be good 👍 Use blinky and export and compare to master |
@OPpuolitaival In cases like this, if an exporter code changes, this PR could run at least few exporters for IAR (improvement for smart tester) |
I vote for getting this in today, and check nightly in the morning. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
The exported project uses project file to set optimization, we can provide this
via misc options. It was recently changed to Ol and this was not handled in our
scripts.
Fixes #11496
Pull request type
Reviewers
Release Notes