Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iar export: fix invalid optmization flag - remove from misc #11498

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 17, 2019

Description

The exported project uses project file to set optimization, we can provide this
via misc options. It was recently changed to Ol and this was not handled in our
scripts.

Fixes #11496

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

The exported project uses project file to set optimization, we can provide this
via misc options. It was recently changed to Ol and this was not handled in our
scripts.
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 17, 2019

I was able to reproduce the failure. And test this fix, all working with it.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 17, 2019

cc @OPpuolitaival - this should fix nightly failures for iar export.

@mark-edgeworth
Copy link
Contributor

Can someone please check that this now works as expected with the IAR tools? Apparently the check would normally only be done on a nightly run (see https://jira.arm.com/browse/MBEDOSTEST-757 comment)

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 18, 2019

I manually tested, but one more test would be good 👍 Use blinky and export and compare to master

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 18, 2019

Can someone please check that this now works as expected with the IAR tools? Apparently the check would normally only be done on a nightly run (see https://jira.arm.com/browse/MBEDOSTEST-757 comment)

@OPpuolitaival In cases like this, if an exporter code changes, this PR could run at least few exporters for IAR (improvement for smart tester)

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 18, 2019

I vote for getting this in today, and check nightly in the morning.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 030e3e1 into ARMmbed:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iar export: multiple -O in the project - fails to build
4 participants