Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for UBLOX_EVK_ODIN_W2 fails in emac test. #11547

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@mtomczykmobica
Copy link
Contributor

mtomczykmobica commented Sep 23, 2019

UBLOX_EVK_ODIN_W2 and MTB_UBLOX_ODIN_W2 haven't multicast implementation so emac multicast test is disabled for those tests.
Function without implementation:

  • add_multicast_group
  • remove_multicast_group
  • set_all_multicast

For boards:

  • MTB_MXCHIP_EMW3166
  • MTB_ADV_WISE_1530
  • MTB_USI_WM_BN_BM_22
    Ipv4 multicast filtering is disable. All use WISE1530 module. Looks like multicast filtring adding is correct by calling mcast_list ioctl with pattern (01:00:5ex:x for ipv4 and 33:33xx for ipv6) but for ipv4 doesn't work and it strongly suggest bug in firmware.

Description

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo

Release Notes

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

SeppoTakalo commented Sep 23, 2019

CC: @mikaleppanen @kjbracey-arm

How does it then receive all multicast traffic?
Sounds like it should be the requirement for EMAC driver.

Instead of skipping the test, we should report this to Ublox and ask them to implement the multicast filtering.

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

SeppoTakalo commented Sep 23, 2019

@ARMmbed/team-ublox Hi, are you aware of this EMAC test failure?

Can it be fixed on your EMAC driver?

@ciarmcom ciarmcom requested review from SeppoTakalo and ARMmbed/mbed-os-maintainers Sep 23, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Sep 23, 2019

@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-4366 branch from c1e9aef to 1bcdd8a Sep 23, 2019
Copy link
Contributor

MarceloSalazar left a comment

Please remove code that involves specific platforms

@MarceloSalazar MarceloSalazar requested a review from ARMmbed/team-ublox Sep 30, 2019
@0xc0170 0xc0170 added needs: work and removed needs: review labels Oct 1, 2019
@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-4366 branch from 1bcdd8a to c8e05fa Oct 2, 2019
@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Oct 2, 2019

@ARMmbed/team-ublox Hi, are you aware of this EMAC test failure?

Can it be fixed on your EMAC driver?

I agree should be resolve in EMAC driver. Should be created new task call: "Emac multicast filtering implementation for ublox emac driver."

Second problem is wise1530 firmware. I'm sure we correctly send ioctl command with multicast filter for ipv4, but filtering doesn't work.

@mtomczykmobica mtomczykmobica requested a review from MarceloSalazar Oct 2, 2019
@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-4366 branch 3 times, most recently from ec5f2ea to dc419b8 Oct 3, 2019
@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Oct 7, 2019

Please remove code that involves specific platforms

Done

@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Oct 7, 2019

@AnttiKauppila

This comment has been minimized.

Copy link
Contributor

AnttiKauppila commented Oct 14, 2019

Please review this

@0xc0170 0xc0170 added needs: review and removed needs: work labels Oct 14, 2019
Copy link
Member

0xc0170 left a comment

Just one alignment fix requested. LGTM otherwise.

Please also rebase, there's travis fix that should be in if you update PR

"name": "network-emac",
"config": {
"NO_SUPPORT_FOR_MULTICAST_FILTER": false,
"NO_SUPPORT_FOR_IPV4_MULTICAST_FILTER": false

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Oct 14, 2019

Member

can you fix alignment here?

This comment has been minimized.

Copy link
@mtomczykmobica

mtomczykmobica Oct 14, 2019

Author Contributor

Fixed.

Copy link
Contributor

MarceloSalazar left a comment

Looks good to me (pending minor formatting issue)

@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-4366 branch from dc419b8 to b27565d Oct 14, 2019
@mtomczykmobica mtomczykmobica requested review from 0xc0170 Oct 14, 2019
@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 14, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 14, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 14, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit befc833 into ARMmbed:master Oct 15, 2019
19 checks passed
19 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8667 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.