Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: change integration fs test format and mount order #11582

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

jamesbeyond
Copy link
Contributor

Description

This test case failed when using the fresh new sd card. it failed to mount.
Changed the setup order to format -> mount in the setup stage. So this is aligned with fs-threaded test, and make sure test case working with a new sd card.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@MarceloSalazar

Release Notes

@ciarmcom ciarmcom requested review from MarceloSalazar and a team September 27, 2019 11:00
@ciarmcom
Copy link
Member

@jamesbeyond, thank you for your changes.
@MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

@jamesbeyond
Copy link
Contributor Author

ping @MarceloSalazar , could you review please ?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

CI started in the background

@MarceloSalazar MarceloSalazar changed the title TEST: change intefration fs test format and mount order TEST: change integration fs test format and mount order Sep 30, 2019
Copy link

@MarceloSalazar MarceloSalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesbeyond thanks for the changes - it makes sense to swap format/mount to align with other tests.
I confirm it works ok on platforms that have storage (L475, K64)

@MarceloSalazar
Copy link

I don't think the CI will be able to test this code unless we add -DINTEGRATION_TESTS in our test scripts.
Any plans to remove this requirement and always run the integration tests with greentea?
Maybe we need to send a separate PR to remove the need for this macro.

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@jamesbeyond
Copy link
Contributor Author

@jamesbeyond thanks for the changes - it makes sense to swap format/mount to align with other tests.
I confirm it works ok on platforms that have storage (L475, K64)

Other test already in the correct order, only just this test.

Hi @0xc0170 , I think this PR ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants