Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Cordio BT Driver setting Host MCU active during Host Wake assert #11644

Merged
merged 2 commits into from Oct 17, 2019

Conversation

@MukundGitHub
Copy link
Contributor

MukundGitHub commented Oct 7, 2019

Description

Update Target Cypress Specific Cordio BT Driver to keep Host MCU active for the duration BT device asserts HOST WAKE. This change fixes race condition in Cypress Cordio driver.

Change Description:
1) Added Rising and falling edge interrupt for Host Wake Pin
2) Keep Host MCU active for the duration of Host Wake Pin Asserted
3) Remove Cordio inactivity virtual functions

Tested with mbed os BT applications:
1) mbed-os-example-ble-LED
2) mbed-os-example-ble-Beacon

Pull request type

[ ] Fix
[ ] Refactor
[ x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

…ve for the duration BT device asserts HOST WAKE. This change fixes race condition in Cypress Cordio driver.
@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Oct 8, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 8, 2019

@MukundGitHub, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-pan Oct 8, 2019
@bulislaw

This comment has been minimized.

Copy link
Member

bulislaw commented Oct 9, 2019

@pan- @donatieng please review

Copy link
Member

0xc0170 left a comment

future reference: It would be easier if these 3 fixes are in separate commits

Copy link
Member

pan- left a comment

Once the initialisation issue is fixed it can get in.

@@ -93,6 +94,7 @@ class CyH4TransportDriver : public cordio::CordioHCITransportDriver {

DigitalInOut bt_host_wake;
DigitalInOut bt_device_wake;
bool bt_host_wake_active;

This comment has been minimized.

Copy link
@pan-

pan- Oct 16, 2019

Member

This value should be initialised in the constructor.

This comment has been minimized.

Copy link
@MukundGitHub

MukundGitHub Oct 16, 2019

Author Contributor

Thanks for review feedback. Addressed the feedback with new commit. Please review the changes and approve the PR Merge request.

@0xc0170 0xc0170 requested a review from pan- Oct 17, 2019
@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 17, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 17, 2019

For future reference, rather than "Address ARM Code review feedback.", just specify what has changed. When we get back to this few days later no one will remember what feedback was it.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 17, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 17, 2019
@0xc0170 0xc0170 merged commit 0efea30 into ARMmbed:master Oct 17, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+1524 bytes) RAM(+136 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8650 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@MukundGitHub MukundGitHub deleted the MukundGitHub:cypress_cordio_driver_host_wake_logic_changes branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.