Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed_rtc_time.h lacks an include guard #11661

Merged
merged 1 commit into from Oct 15, 2019
Merged

mbed_rtc_time.h lacks an include guard #11661

merged 1 commit into from Oct 15, 2019

Conversation

@Alex-EEE
Copy link
Contributor

Alex-EEE commented Oct 9, 2019

Adds a missing include guard

Description

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

This PR adds it
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Oct 9, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 9, 2019

@Alex-EEE, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

hugueskamba left a comment

Thank you.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 14, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 14, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 15, 2019

This is strange but Travis reports failure for events. I don't find it related however failed already 2x time with compilation error.

@Alex-EEE Can you reproduce it locally? There's command shown right after the error to test it locally

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 15, 2019

Scratch that, something was wrong with Travis, I restarted again to make sure the error is valid.

All good here

@0xc0170 0xc0170 merged commit 119e99f into ARMmbed:master Oct 15, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8710 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.