Skip to content

Allow WhdAccessPoint scan results with extended parameters #11662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2019
Merged

Allow WhdAccessPoint scan results with extended parameters #11662

merged 1 commit into from
Oct 24, 2019

Conversation

cydriftcloud
Copy link
Contributor

@cydriftcloud cydriftcloud commented Oct 10, 2019 •
edited
Loading

Add WhdAccessPoint to include additional WHD scan info

  • To save memory, only move assignment is supported for WhdAccessPoint
  • Add scan_whd to scan for WhdAccessPoint with extended parameters such as BSS_TYPE, IE_DATA and IE_LEN
  • Set set_blocking(false) to unsupported by return NSAPI_ERROR_UNSUPPORTED

Description

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from maclobdell and a team October 10, 2019 01:00
@ciarmcom
Copy link
Member

@cydriftcloud, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@cydriftcloud
Copy link
Contributor Author

@maclobdell Please help to review. Thanks.

0xc0170
0xc0170 requested changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks fine to me

@cydriftcloud
Allow WhdAccessPoint scan result with extended parameters
7b16166 
- Add WhdAccessPoint to include additional WHD scan info
- To save memory, only move assignment is supported for WhdAccessPoint
- Add scan_whd to scan for WhdAccessPoint
- Set set_blocking(false) to unsupported by return NSAPI_ERROR_UNSUPPORTED
@cydriftcloud cydriftcloud force-pushed the pr-dev/sta-extended-scan branch from f0084d8 to 7b16166 Compare October 23, 2019 21:44
cydriftcloud
cydriftcloud commented Oct 23, 2019
View reviewed changes
Copy link
Contributor Author

@cydriftcloud cydriftcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header added.

@ifyall ifyall mentioned this pull request Oct 23, 2019
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2019

CI started while @ARMmbed/mbed-os-ipcore reviews

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit ab931ee into ARMmbed:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

+1 more reviewer

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cydriftcloud @ciarmcom @0xc0170 @mbed-ci @michalpasztamobica