Skip to content

GREENTEA: init trace if trace is enabled in json #11695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019
Merged

GREENTEA: init trace if trace is enabled in json #11695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion features/frameworks/greentea-client/source/greentea_test_env.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include "greentea-client/test_env.h"
#include "greentea-client/greentea_serial.h"
#include "greentea-client/greentea_metrics.h"

#include "mbed_trace.h"

/**
* Generic test suite transport protocol keys
Expand Down Expand Up @@ -84,6 +84,10 @@ void _GREENTEA_SETUP_COMMON(const int timeout, const char *host_test_name, char
}
}

#ifdef MBED_CONF_MBED_TRACE_ENABLE
mbed_trace_init();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be seen as nice to have but not certain enabling trace would add also this call by default to greentea. It is known that this call needs to come from an app if tracing is used.

cc @SeppoTakalo

#endif

greentea_notify_version();
greentea_notify_timeout(timeout);
greentea_notify_hosttest(host_test_name);
Expand Down