Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCU_NRF52840: Switches to correct Product Anomaly Notification(PAN) macro #11706

Merged

Conversation

@VeijoPesonen
Copy link
Contributor

VeijoPesonen commented Oct 18, 2019

Description

A wrongly named macro was used rendering available workaround for the NRF52840 MCU useless. The anomaly is shared between the two MCU revisions and all engineering samples.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnttiKauppila
@kivaisan
@0xc0170
@teetak01

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170, AnttiKauppila and kivaisan Oct 18, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 18, 2019

@ciarmcom ciarmcom requested review from teetak01 and ARMmbed/mbed-os-maintainers Oct 18, 2019
@40Grit

This comment has been minimized.

Copy link

40Grit commented Oct 18, 2019

@loverdeg-ep

This comment has been minimized.

Copy link
Contributor

loverdeg-ep commented Oct 18, 2019

@maclobdell wondering if this is why EP_AGORA fails RTC tests

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 18, 2019

@maclobdell wondering if this is why EP_AGORA fails RTC tests

Can we retest?

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

Started CI meanwhile

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@40Grit

This comment has been minimized.

Copy link

40Grit commented Oct 22, 2019

Is this good to merge?

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 22, 2019

I was waiting for requested reviewers to review , should be all good as change is simple.

@0xc0170 0xc0170 merged commit 97ef25f into ARMmbed:master Oct 22, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8634 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@VeijoPesonen VeijoPesonen deleted the VeijoPesonen:nrf52840_fix_product_anomaly_macro branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.