Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure modem echo is off before sending other AT commands #11719

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@wajahat-ublox
Copy link
Member

wajahat-ublox commented Oct 21, 2019

Description

Currently three AT commands are sent together and response for OK is checked only for last command. This means that there can be a case where modem echo remains on as it sent OK to AT+CFUN=1 command but did not receive first two commands (reason being not fully powered up yet).
This can affect the functionality of cellular APIs and test cases. It is better to first ensure that modem is responding to ATE0 command and then send other commands.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Oct 21, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 21, 2019

@wajahat-ublox, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@fahim-ublox

This comment has been minimized.

Copy link
Contributor

fahim-ublox commented Oct 25, 2019

@MarceloSalazar it has fixed random failure in cellular integration test introduced recently. Please update us if you want something to change !

Added @RobMeades

@wajahat-ublox

This comment has been minimized.

Copy link
Member Author

wajahat-ublox commented Oct 29, 2019

@0xc0170
0xc0170 approved these changes Nov 4, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 4, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 18d4adf into ARMmbed:master Nov 4, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8708 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Nov 4, 2019
@wajahat-ublox wajahat-ublox deleted the wajahat-ublox:echo_fix branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.