Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxp LPC55S69: fix i2c pin mapping #11734

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@maciejbocianski
Copy link
Member

maciejbocianski commented Oct 23, 2019

Description

Fix LPC55S69 I2C pin mapping on arduino A5/A4 pins

Target page also needs to be updated (https://os.mbed.com/platforms/LPCXpresso55S69/)

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond
@ARMmbed/team-nxp

Release Notes

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 23, 2019

@maciejbocianski, thank you for your changes.
@jamesbeyond @maclobdell @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from jamesbeyond, maclobdell and ARMmbed/mbed-os-maintainers Oct 23, 2019
@0xc0170 0xc0170 requested a review from ARMmbed/team-nxp Oct 23, 2019
@mmahadevan108

This comment has been minimized.

Copy link
Contributor

mmahadevan108 commented Oct 23, 2019

Per the schematics P0_13 is I2C_SDA and P0_14 is I2C_SCL. I have tested the I2C with the FPGA sheid board and it passed the I2C test.

Board Schematics can be accessed from the below link:
https://www.nxp.com/products/processors-and-microcontrollers/arm-microcontrollers/general-purpose-mcus/lpc5500-cortex-m33/lpcxpresso55s69-development-board:LPC55S69-EVK

@maciejbocianski

This comment has been minimized.

Copy link
Member Author

maciejbocianski commented Oct 23, 2019

@mmahadevan108
True, the fix should go here (

)

@mmahadevan108

This comment has been minimized.

Copy link
Contributor

mmahadevan108 commented Oct 23, 2019

@mmahadevan108
True, the fix should go here (

)

Thank you, I see the issue. Could you please help update the PR.

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:nxp_lpc55s69_i2c_pinmap_fix branch from 18ffcc7 to bb91975 Oct 23, 2019
@maciejbocianski

This comment has been minimized.

Copy link
Member Author

maciejbocianski commented Oct 23, 2019

Copy link
Contributor

mmahadevan108 left a comment

Thank you

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 24, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 24, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 24, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 58ef53a into ARMmbed:master Oct 24, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8658 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.