Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpga i2c test: limit tested peripherals #11743

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@maciejbocianski
Copy link
Member

maciejbocianski commented Oct 24, 2019

Due to lack of i2c_free function switching between peripherals cause i2c tests failures on some targets. Limit testing to single peripheral until i2c_free is implemented.

Description

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond

Release Notes

Due to lack of i2c_free function switching between peripherals
cause i2c tests failures on some targets.
For now limit testing to single peripheral.
@ciarmcom ciarmcom requested review from jamesbeyond and ARMmbed/mbed-os-maintainers Oct 24, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 24, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

Due to lack of i2c_free function switching between peripherals cause i2c tests failures on some targets. Limit testing to single peripheral until i2c_free is implemented.

Is this tracked as an issue anywhere?

Copy link
Contributor

jamesbeyond left a comment

LGTM

@maciejbocianski

This comment has been minimized.

Copy link
Member Author

maciejbocianski commented Oct 25, 2019

Due to lack of i2c_free function switching between peripherals cause i2c tests failures on some targets. Limit testing to single peripheral until i2c_free is implemented.

Is this tracked as an issue anywhere?

I don't think it is.
It was added in new HAL I2C API

void i2c_free(i2c_t *obj);

I would suggest adding i2c_free in Mbed 6.0.
@jamesbeyond @0xc0170

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 28, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 28, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 3efae20 into ARMmbed:master Oct 28, 2019
20 checks passed
20 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8689 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.